Prevent chain files from being saved in install directory#2835
Merged
joeyballentine merged 9 commits intomainfrom May 8, 2024
Merged
Prevent chain files from being saved in install directory#2835joeyballentine merged 9 commits intomainfrom
joeyballentine merged 9 commits intomainfrom
Conversation
RunDevelopment
requested changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had numerous reports of people thinking that it is a good idea to save their chains in chaiNNer's install dir, only to lose all their chain files after updating (for example, #1756).
This PR should prevent this in the future. Now, if someone tries to save to this directory, it will error and tell them to pick a different one. Also, it checks on startup if any chain files are stored in this directory (i.e. if someone moved them there manually) and gives a warning before starting up.
One concern is that this still applies in portable mode. It's most likely fine for people to put chain files in their portable folder, so should we not do these things for portable installs?