Skip to content

Remove sleep in upscale #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeyballentine merged 3 commits into from
May 17, 2024
Merged

Remove sleep in upscale #2853

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50e2011
Remove sleep in upscale
joeyballentine May 17, 2024
52e160e
replace with time.sleep(0)
joeyballentine May 17, 2024
c822822
Update backend/src/process.py
joeyballentine May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backend/src/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,11 @@ def aborted(self) -> bool:

@property
def paused(self) -> bool:
time.sleep(0.001)
# Python is single-threaded, so it's necessary for this thread to yield, so other threads can do some work.
# This is necessary because the thread for accepting the `/pause` endpoint would not be able to accept requests otherwise.
# This in turn would mean that `self.progress.paused` would never be set to True.
# For more information, see https://github.com/chaiNNer-org/chaiNNer/pull/2853
time.sleep(0)
return self.progress.paused

def set_progress(self, progress: float) -> None:
Expand Down