Only copy non-writeable image when CPU upscaling#2860
Merged
joeyballentine merged 3 commits intomainfrom May 18, 2024
Merged
Conversation
RunDevelopment
approved these changes
May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying takes time and memory. Why waste this time and memory if we are just going to immediately copy the image to the GPU?
Now the copy will only happen if the user is upscaling with CPU. On anything else, the image is simply moved to a tensor (sharing the same memory) after being made writeable, then copied to the GPU. The image is then set back to readonly.
This made a significant cut to processing time.