Add "order" dropdown for both spritesheet nodes#2878
Merged
joeyballentine merged 4 commits intomainfrom May 19, 2024
Merged
Conversation
Member
|
The "row x column" and "column x row" names are confusing. The infix "x" typically denotes multiplication which most people think of as commutative. By this interpretation, these two options describe the same thing ( The terms you are looking for are row major and column major. Unfortunately, these terms aren't really used outside CS and math, so we need to explain them. I would probably give a short description of both and then use code blocks to visually show the difference like this: Also, the description should be a hint (so with a little (i)) IMO. We can't expect people to know this, so we should make the explanation easy to access. |
backend/src/packages/chaiNNer_standard/image/batch_processing/split_spritesheet.py
Outdated
Show resolved
Hide resolved
RunDevelopment
approved these changes
May 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2851