Skip to content

Add a "simple" mode for saving video#2879

Merged
joeyballentine merged 8 commits intomainfrom
simple-video
May 19, 2024
Merged

Add a "simple" mode for saving video#2879
joeyballentine merged 8 commits intomainfrom
simple-video

Conversation

@joeyballentine
Copy link
Member

@joeyballentine joeyballentine commented May 19, 2024

People often have confusion as to why the quality (crf) slider is what it is, or what the preset option does. If you don't know FFMPEG, then those things make no sense. Those users probably also don't know anything about encoders or formats.

So, I made a "simple" mode. It gives only a few options for formats, and uses a quality slider from 0-100 that sets both the CRF and preset values. This should make the node much more easily usable and intuitive for non-superusers

Open questions:

  1. Should AVI be an option for lossless video?
  2. Should we use HEVC instead of H.265 in the parens?

image

@RunDevelopment
Copy link
Member

Should AVI be an option for lossless video?

Not sure. If it's easy to add, then why not. I just think that it should have "lossless" in the name of the option if you add it.

Should we use HEVC instead of H.265 in the parens?

I think both are used, so maybe both?

@joeyballentine
Copy link
Member Author

I decided not to add AVI for now. We can add that if anyone wants it. I also added a AVC and HEVC to the h264 and h265 labels, respectively. Also, I made it hide the quality slider for GIF (like advanced mode does)

@RunDevelopment
Copy link
Member

I think we need a label for the additional params text box. Otherwise gtg

@joeyballentine joeyballentine merged commit 6219950 into main May 19, 2024
@joeyballentine joeyballentine deleted the simple-video branch May 19, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants