Merged
Conversation
Member
|
Will the |
Member
Author
|
It doesn't. I tested this. |
Member
Author
|
Gonna merge this so it's fixed in the nightly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some numpy arrays cannot be set to writeable -- this seems to include arrays that come from rust/chainner-ext. These would cause errors from attempting to make them writeable.
So, I just wrapped it with a try/except, and made it copy if it cannot be set to writeable. Easy fix, and we still get the optimization from it if it is able to be set to writeable