Use "put_nowait" for event queue#2886
Merged
joeyballentine merged 2 commits intomainfrom May 20, 2024
Merged
Conversation
Member
|
Could you make the functions in the executor that no longer need to be async normal function again? |
RunDevelopment
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why wait and waste time when not waiting works?
Based on skimming a trace, this actually does appear to make the SSE requests no longer blocking, I think. I could be entirely wrong though, since put_nowait theoretically doesnt do anything different with an infinite size queue