Add special suggestion for Math and Compare nodes in node selector#2908
Merged
joeyballentine merged 4 commits intochaiNNer-org:mainfrom May 24, 2024
Merged
Conversation
joeyballentine
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to write chains with Math and Compare nodes. The context node selector will now parse search queries like
*4and create a Math node that multiplies the given number by 4. Example:Special suggestions are defined by the backend via a new suggestions API. It's a pretty flexible system, so we can use it for other nodes as well in the future.