Add similarity check to ONNX model conversions#2915
Merged
joeyballentine merged 2 commits intochaiNNer-org:mainfrom May 30, 2024
Merged
Add similarity check to ONNX model conversions#2915joeyballentine merged 2 commits intochaiNNer-org:mainfrom
joeyballentine merged 2 commits intochaiNNer-org:mainfrom
Conversation
Member
|
Errors when running in fp16 mode: Full stack trace: |
Member
Author
|
Okay, I think it should work now. |
Member
joeyballentine
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #2585.
This adds a new check to ensure that the ONNX models of PyTorch models produce the same outputs. This new check is options and off by default, because it requires an ONNX runtime.
I also cleaned up some other code along the way.
To the reviewer: please test this. I don't really do ONNX conversions, so I just tested it on a few models and it seemed to work.