Add UI for anchor/position dropdowns#2940
Merged
joeyballentine merged 2 commits intochaiNNer-org:mainfrom Jun 4, 2024
Merged
Conversation
joeyballentine
approved these changes
Jun 4, 2024
Member
joeyballentine
left a comment
joeyballentine
left a comment
There was a problem hiding this comment.
This is really cool, good job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new preferred style for dropdowns that describe anchors or positions. The Text as Image node is that only node using this new style right now, but I plan to use it for #2933/#777 as well. We might even use it for Blend Images, but that needs some more work.
Other changes:
useValidDropDownValuehook to ensure valid dropdown values. This removes some code duplication.