Add support for 3 TIFF compression modes#2970
Merged
joeyballentine merged 1 commit intochaiNNer-org:mainfrom Jul 1, 2024
Merged
Add support for 3 TIFF compression modes#2970joeyballentine merged 1 commit intochaiNNer-org:mainfrom
joeyballentine merged 1 commit intochaiNNer-org:mainfrom
Conversation
joeyballentine
approved these changes
Jul 1, 2024
Member
joeyballentine
left a comment
joeyballentine
left a comment
There was a problem hiding this comment.
Maybe in the future we can use the image crate's tiff encoding. I'm guessing it's probably better than opencv 😆
Member
Author
I just looked, and it looks like it has even fewer features :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #2950.
This PR adds support for None, LZW, and ZIP compression for 8 and 16 bit images. This is the best that OpenCV would let me do.
So OpenCV's TIFF compression is completely fucked. Not only did they forget to define the enum constants for TIFF compression modes, the compression modes themselves don't really work. E.g. it says that it support a JPEG compression mode, but this mode always errors no matter what I do. For 32 bit, OpenCV only supports a single compression mode. Not even NONE is an option.