Fix audio not saving in save video node (from fix left on issue)#3174
Merged
joeyballentine merged 1 commit intomainfrom Oct 22, 2025
Merged
Fix audio not saving in save video node (from fix left on issue)#3174joeyballentine merged 1 commit intomainfrom
joeyballentine merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where audio was not being properly saved when using the save video node. The fix reorganizes the audio processing logic, adds better error handling, and corrects the order of video and audio streams in the ffmpeg output command.
Key Changes:
- Corrected the order of video and audio streams passed to
ffmpeg.output()(video first, then audio) - Added validation to check if the video file exists before attempting audio processing
- Improved error handling with specific exception catching and cleanup logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
joeyballentine
added a commit
that referenced
this pull request
Oct 22, 2025
joeyballentine
added a commit
that referenced
this pull request
Oct 22, 2025
joeyballentine
added a commit
that referenced
this pull request
Oct 23, 2025
…andling (#3140) * Initial plan * Add boolean output to regex find node for match detection Co-authored-by: joeyballentine <34788790+joeyballentine@users.noreply.github.com> * Update regex find node description to document new Found output Co-authored-by: joeyballentine <34788790+joeyballentine@users.noreply.github.com> * Update backend/src/packages/chaiNNer_standard/utility/text/regex_find.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix audio not saving in save video node (from fix left on issue) (#3174) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joeyballentine <34788790+joeyballentine@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this and it appears to work. Fixes #1774
Thanks @gwynnPalmer and @pokepress