Skip to content

Conversation

@jackleslie
Copy link
Contributor

@jackleslie jackleslie commented Dec 29, 2021

Context

Fixes #126, alternative solution to #127

Instead of implementing git commit signing into the action, we could allow an input option to disable the setupUser function so that consumers can use their own git user to create commits in this action.

Changes

  • Add setupGitUser boolean input option
    • Updated @actions/core to be able to use getBooleanInput
    • Default to true
  • Don't run gitUtils.setupUser() if setupGitUser is false
  • Update docs

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2021

🦋 Changeset detected

Latest commit: f4b970b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/action Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jackleslie
Copy link
Contributor Author

@Andarist @mitchellhamilton just bumping this if that's okay

Would you prefer this approach or the one in #127?

@Andarist
Copy link
Member

Andarist commented Jan 6, 2022

@jacklesliewise the only concern I have with this PR is the nit about the name that has been chosen for the option. I think this might be useful to some people in other situations than the one covered by #127 so this should land either way (regardless of what we decide for the #127 but most likely we'll close it, for the time being, we can always revisit this in the future).

@jackleslie
Copy link
Contributor Author

Thanks @Andarist, I've closed #127 for now and updated this PR as per your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to enable commit signing

3 participants