-
-
Notifications
You must be signed in to change notification settings - Fork 397
Comment changeset status in PRs #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bluwy
wants to merge
13
commits into
main
Choose a base branch
from
comment-pr-changeset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0f2b7f6
Initial implementation
bluwy 0c33f17
Fix
bluwy 513d3b1
fix
bluwy bdfd7f0
fix
bluwy 3f05264
Make it look nicer
bluwy b3bbf47
Update docs
bluwy b4b967a
Rename to pr-status-comment
bluwy 7457ddb
Remove outputs
bluwy 6057580
Update path
bluwy 8188bb1
update name
bluwy 65ef483
Checkout PR in a detached worktree (#626)
Andarist 7c7f15b
Move comment to separate job
bluwy d288cad
Loosen event requirement
bluwy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # changesets/action/pr-status | ||
|
|
||
| This action generates the changeset status in PRs, e.g. whether it has changeset files and which packages will be released if the PR is merged. | ||
|
|
||
| It requires the repo to be checked out, and automatically fetches the PR head ref into a temporary detached worktree in order to infer the changed files and packages. It also requires the [`pull_request_target`](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target) event to be triggered in order to have permissions to comment on the PR and to work in PRs from forks. | ||
|
|
||
| You can also use the [`pull_request`](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request) event if you prefer to lock permissions down and not run for PRs from forks. Make sure to add an if check to prevent the action from failing in fork PRs: | ||
|
|
||
| ```yaml | ||
| jobs: | ||
| pr-status: | ||
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| # ... | ||
| ``` | ||
|
|
||
| See the [action metadata](action.yml) for details on the inputs and outputs. | ||
|
|
||
| > [!WARNING] | ||
| > **Do not run untrusted code** when using the `pull_request_target` event. The example below only checks out code and does not run any code from the PR. Read more about the `pull_request_target` event in the [GitHub documentation](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target). | ||
|
|
||
| ## Example setup | ||
|
|
||
| ```yaml | ||
| # .github/workflows/comment-changeset-pr-status.yml | ||
| name: Comment changeset status in PRs | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| pr-status: | ||
| runs-on: ubuntu-slim | ||
| permissions: | ||
| contents: read # to check out files in the repo | ||
| outputs: | ||
| commentBody: ${{ steps.pr-status.outputs.commentBody }} | ||
| steps: | ||
| - name: Check out repo | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Generate status | ||
| id: pr-status | ||
| uses: changesets/action/pr-status@v1 | ||
|
|
||
| comment: | ||
| needs: pr-status | ||
| runs-on: ubuntu-slim | ||
| permissions: | ||
| pull-requests: write # to create and update comments on PRs | ||
| steps: | ||
| - name: Comment on PR | ||
| uses: mshick/add-pr-comment@v3 | ||
| with: | ||
| message-id: changeset-pr-status | ||
| message: ${{ needs.pr-status.outputs.commentBody }} | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: Changesets - PR Status | ||
| description: Generate the changeset status in PRs | ||
| runs: | ||
| using: node24 | ||
| main: ../dist/pr-status.js | ||
| inputs: {} | ||
| outputs: | ||
| commentBody: | ||
| description: The generated comment body to present the changeset status in PRs. | ||
| branding: | ||
| icon: package | ||
| color: blue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,16 @@ | ||
| import { defineConfig } from 'rolldown' | ||
| import { defineConfig } from "rolldown"; | ||
|
|
||
| export default defineConfig({ | ||
| input: 'src/index.ts', | ||
| input: { | ||
| index: "src/index.ts", | ||
| ["pr-status"]: "src/pr-status/index.ts", | ||
| }, | ||
| output: { | ||
| dir: 'dist', | ||
| format: 'esm', | ||
| dir: "dist", | ||
| format: "esm", | ||
| cleanDir: true, | ||
| minify: true, | ||
| comments: false, | ||
| }, | ||
| platform: 'node', | ||
| }) | ||
| platform: "node", | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import * as core from "@actions/core"; | ||
| import * as github from "@actions/github"; | ||
| import { getCommentMessage } from "./message.ts"; | ||
|
|
||
| (async () => { | ||
| const context = github.context.payload.pull_request; | ||
| if (!context) { | ||
| core.error( | ||
| "This action should only be run on `pull_request_target` or `pull_request` events", | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| core.info("Creating comment message..."); | ||
| const commentBody = await getCommentMessage(context); | ||
| core.setOutput("commentBody", commentBody); | ||
| core.info("Done!"); | ||
| })().catch((err) => { | ||
| core.error(err); | ||
| core.setFailed(err.message); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| import * as github from "@actions/github"; | ||
| import getReleasePlan from "@changesets/get-release-plan"; | ||
| import type { | ||
| ComprehensiveRelease, | ||
| ReleasePlan, | ||
| VersionType, | ||
| } from "@changesets/types"; | ||
| import { markdownTable } from "markdown-table"; | ||
| import { | ||
| getNewChangesetTemplateContent, | ||
| getNewChangesetUrl, | ||
| } from "./template.ts"; | ||
| import { withPullRequestWorktree } from "./worktree.ts"; | ||
|
|
||
| type PullRequestContext = NonNullable< | ||
| typeof github.context.payload.pull_request | ||
| >; | ||
|
|
||
| export async function getCommentMessage(context: PullRequestContext) { | ||
| const { releasePlan, templateContent } = await withPullRequestWorktree( | ||
| context, | ||
| async ({ cwd, baseRef }) => { | ||
| const releasePlan = await getReleasePlan(cwd, baseRef); | ||
| const templateContent = await getNewChangesetTemplateContent( | ||
| cwd, | ||
| baseRef, | ||
| context.title, | ||
| ); | ||
|
|
||
| return { | ||
| releasePlan, | ||
| templateContent, | ||
| }; | ||
| }, | ||
| ); | ||
|
|
||
| const newChangesetUrl = getNewChangesetUrl( | ||
| context.head.repo.html_url, | ||
| context.head.ref, | ||
| templateContent, | ||
| ); | ||
|
|
||
| if (releasePlan.changesets.length > 0) { | ||
| return getApproveMessage(context.head.sha, newChangesetUrl, releasePlan); | ||
| } else { | ||
| return getAbsentMessage(context.head.sha, newChangesetUrl, releasePlan); | ||
| } | ||
| } | ||
|
|
||
| function getApproveMessage( | ||
| commitSha: string, | ||
| newChangesetUrl: string, | ||
| releasePlan: ReleasePlan, | ||
| ) { | ||
| return `\ | ||
| ### 🦋 Changeset detected | ||
|
|
||
| Latest commit: ${commitSha} | ||
|
|
||
| **The changes in this PR will be included in the next version bump.** | ||
|
|
||
| ${getReleasePlanMessage(releasePlan)} | ||
|
|
||
| Not sure what this means? [Click here to learn what changesets are](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md). | ||
|
|
||
| [Click here if you're a maintainer who wants to add another changeset to this PR](${newChangesetUrl})`; | ||
| } | ||
|
|
||
| function getAbsentMessage( | ||
| commitSha: string, | ||
| newChangesetUrl: string, | ||
| releasePlan: ReleasePlan, | ||
| ) { | ||
| return `\ | ||
| ### ⚠️ No Changeset found | ||
|
|
||
| Latest commit: ${commitSha} | ||
|
|
||
| Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.** | ||
|
|
||
| ${getReleasePlanMessage(releasePlan)} | ||
|
|
||
| [Click here to learn what changesets are, and how to add one](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md). | ||
|
|
||
| [Click here if you're a maintainer who wants to add a changeset to this PR](${newChangesetUrl})`; | ||
| } | ||
|
|
||
| function getReleasePlanMessage(releasePlan: ReleasePlan) { | ||
| const publishableReleases = releasePlan.releases.filter( | ||
| (r) => r.type !== "none", | ||
| ) as (ComprehensiveRelease & { type: Exclude<VersionType, "none"> })[]; | ||
|
|
||
| const table = markdownTable([ | ||
| ["Name", "Type"], | ||
| ...publishableReleases.map((release) => { | ||
| return [ | ||
| release.name, | ||
| { | ||
| major: "Major", | ||
| minor: "Minor", | ||
| patch: "Patch", | ||
| }[release.type], | ||
| ]; | ||
| }), | ||
| ]); | ||
|
|
||
| let summary = "This PR includes "; | ||
| if (releasePlan.changesets.length === 0) { | ||
| summary += "no changesets"; | ||
| } else { | ||
| summary += `changesets to release ${publishableReleases.length} package`; | ||
| if (publishableReleases.length !== 1) { | ||
| summary += "s"; | ||
| } | ||
| } | ||
|
|
||
| return `\ | ||
| <details> | ||
| <summary>${summary}</summary> | ||
|
|
||
| ${ | ||
| publishableReleases.length > 0 | ||
| ? table | ||
| : "When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types" | ||
| } | ||
|
|
||
| </details>`; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { getChangedPackagesSinceRef } from "@changesets/git"; | ||
| import { humanId } from "human-id"; | ||
|
|
||
| export function getNewChangesetUrl( | ||
| headRepoUrl: string, | ||
| headRef: string, | ||
| templateContent: string, | ||
| ) { | ||
| const fileName = humanId({ separator: "-", capitalize: false }); | ||
| return `${headRepoUrl}/new/${headRef}?filename=.changeset/${fileName}.md&value=${encodeURIComponent(templateContent)}`; | ||
| } | ||
|
|
||
| export async function getNewChangesetTemplateContent( | ||
| cwd: string, | ||
| baseRef: string, | ||
| prTitle: string, | ||
| ) { | ||
| const changedPackages = await getChangedPackagesSinceRef({ | ||
| cwd, | ||
| ref: baseRef, | ||
| }); | ||
|
|
||
| return `\ | ||
| --- | ||
| ${changedPackages.map((p) => `"${p.packageJson.name}": patch`).join("\n")} | ||
| --- | ||
|
|
||
| ${prTitle} | ||
| `; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.