Simplify getChangelogEntry#632
Open
bluwy wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 84bd40d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copied the function from https://github.com/changesets/changesets/blob/eaea8a45aca36f2c87adf888e3a73cd2c3a9ee39/packages/release-utils/src/utils.ts#L33
Which I've updated for next in changesets/changesets#1962. This removes a ton of dependencies and slightly reduces our bundle size:
We also don't have to update the deps (they're outdated). We could import this from
@changesets/release-utilsif we want, but the changes I made is innext. And I'm also not sure if we want to start using@changesets/release-utilshere. So I went with the simple approach and copy the function to here.I totally understand if we do not feel like doing this now. I feel that it's ok since we've added more tests for it, and it only affects the version PR description. But I'll leave it to you to see if we should do this now, or later.