Skip to content

add index of the point clicked#151

Merged
Hermanya merged 1 commit into
chart-kit:masterfrom
MD1990:patch-2
Sep 3, 2019
Merged

add index of the point clicked#151
Hermanya merged 1 commit into
chart-kit:masterfrom
MD1990:patch-2

Conversation

@MD1990

@MD1990 MD1990 commented Sep 3, 2019

Copy link
Copy Markdown
Contributor

Please look into this and approve as I was not able to proceed or I will have to change the plugin thanks

Please look into this and approve as I was not able to proceed or I will have to change the plugin thanks
@MD1990

MD1990 commented Sep 3, 2019

Copy link
Copy Markdown
Contributor Author

Please let me know when you read this. Thanks

@Hermanya Hermanya self-requested a review September 3, 2019 14:03

@Hermanya Hermanya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I can publish this new version in about 8 hours 😄

Comment thread src/line-chart.js
index: i,
value: x,
dataset,
dataset,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove this trailing empty space?

@Hermanya Hermanya merged commit 4171a87 into chart-kit:master Sep 3, 2019
@Hermanya

Hermanya commented Sep 3, 2019

Copy link
Copy Markdown
Contributor

Thank you for your contribution. This is now available in v3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants