Multiple Lines on Graph Functionality#24
Merged
Conversation
Hermanya
reviewed
Jul 7, 2018
| "_main": "./node_modules/react-native-scripts/build/bin/crna-entry.js", | ||
| "main": "./index.js", | ||
| "main": "./node_modules/react-native-scripts/build/bin/crna-entry.js", | ||
| "_main": "./index.js", |
Contributor
There was a problem hiding this comment.
.DS_Store and package-lock.json need to be removed. We already have yarn.lock
The package.json change needs to be removed. I know that it sucks, the example should really be in a subfolder, so that we don't have this problem.
Hermanya
reviewed
Jul 7, 2018
| paddingRight, | ||
| paddingTop, | ||
| data: data.datasets[0].data | ||
| // data: data.datasets[0].data |
Contributor
There was a problem hiding this comment.
And please remove this commented code.
Contributor
|
I run your clone. The graph looks somewhat confusing. Could you share a screenshot of how you are using this graph? How do you show which line represents what? |
Contributor
|
Fixed all the minor things. @alimuqaddas congrats on your first Open Source Contribution 👍 thank you very much 😄 |
|
do we have document for multiple lines on graph functionality? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I have created the multiple lines graph functionality. I hope its something valuable because after surfing a lot on web i found nothing interesting.