Skip to content

StackedBarChart - use full width when legend is hidden #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hermanya merged 1 commit into from
Feb 8, 2021
Merged

StackedBarChart - use full width when legend is hidden #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/StackedBarChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ class StackedBarChart extends AbstractChart<
withVerticalLabels = true,
segments = 4,
decimalPlaces,
percentile = false
percentile = false,
hideLegend = false
} = this.props;

const { borderRadius = 0 } = style;
Expand All @@ -209,7 +210,8 @@ class StackedBarChart extends AbstractChart<
border = max;
}

var stackedBar = data.legend && data.legend.length == 0 ? false : true;
const showLegend = !hideLegend && data.legend && data.legend.length != 0;
const stackedBar = showLegend;

return (
<View style={style}>
Expand Down Expand Up @@ -267,8 +269,7 @@ class StackedBarChart extends AbstractChart<
stackedBar
})}
</G>
{data.legend &&
data.legend.length != 0 &&
{showLegend &&
this.renderLegend({
...config,
legend: data.legend,
Expand Down