Additional prop to customize vertical labels height#480
Merged
Hermanya merged 2 commits intoFeb 8, 2021
Merged
Conversation
Contributor
|
Thank you for your contribution. Changes from all 3 PRs are now available in v6.11.0 👍 |
akakaze
added a commit
to akakaze/react-native-chart-kit
that referenced
this pull request
Jul 11, 2022
The verticalLabelsHeightPercentage added in chart-kit#480 is not brought in, so it does not have the expected effect. Bring verticalLabelsHeightPercentage into config to make it take effect.
akakaze
added a commit
to akakaze/react-native-chart-kit
that referenced
this pull request
Jul 11, 2022
The verticalLabelsHeightPercentage added in chart-kit#480 is not brought in, so it does not have the expected effect. Bring verticalLabelsHeightPercentage into config to make it take effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The space used for vertical labels is hardcoded to be 25% of the total chart height. When chart height becomes high, such a big percentage becomes visible noticeable, and, since the labels are usually short, most of this space is actually unused.
This PR introduces new props,
verticalLabelsHeightPercentagewhich can be used to customize this percentage.