Skip to content

Migrate from Singleton client class to using parameter in Resource methods#24

Merged
chasleslr merged 2 commits into
developfrom
feature/refactor-connection-2
Feb 7, 2022
Merged

Migrate from Singleton client class to using parameter in Resource methods#24
chasleslr merged 2 commits into
developfrom
feature/refactor-connection-2

Conversation

@chasleslr
Copy link
Copy Markdown
Owner

No description provided.

Charles Larivier added 2 commits February 6, 2022 17:01
Signed-off-by: Charles Larivier <charles@dribbble.com>
…ument in resource methods

Signed-off-by: Charles Larivier <charles@dribbble.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2022

Codecov Report

Merging #24 (7e8115c) into develop (4c236b4) will decrease coverage by 0.01%.
The diff coverage is 96.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
- Coverage    98.48%   98.47%   -0.02%     
===========================================
  Files           29       29              
  Lines         1191     1181      -10     
===========================================
- Hits          1173     1163      -10     
  Misses          18       18              
Impacted Files Coverage Δ
tests/test_metabase.py 100.00% <ø> (ø)
src/metabase/resources/user.py 92.85% <57.14%> (+0.17%) ⬆️
src/metabase/resources/field.py 98.11% <66.66%> (+0.01%) ⬆️
src/metabase/resources/table.py 97.18% <84.61%> (+0.04%) ⬆️
src/metabase/metabase.py 94.87% <100.00%> (-0.88%) ⬇️
src/metabase/resource.py 96.15% <100.00%> (-0.15%) ⬇️
src/metabase/resources/card.py 100.00% <100.00%> (ø)
src/metabase/resources/database.py 100.00% <100.00%> (ø)
src/metabase/resources/dataset.py 100.00% <100.00%> (ø)
src/metabase/resources/metric.py 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6c30a...7e8115c. Read the comment docs.

@chasleslr chasleslr merged commit e5b6eb7 into develop Feb 7, 2022
@chasleslr chasleslr deleted the feature/refactor-connection-2 branch February 7, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant