Conversation
link2xt
force-pushed
the
forward-in_reply_to
branch
from
2a55ef2 to
c29149e
Compare
This function is used to lookup the chat by `References` and `In-Reply-To` header, so it does not make sense to return trashed message when there is another non-trashed message in one of these headers with a real chat ID.
For forwarded messages, parent message is not a quoted message.
WofWca
added a commit
that referenced
this pull request
Mar 28, 2026
This change might be controversal. According to the `test_forward_quote` test (introduced in 6b3b33d, #2843), this behavior is intentional. That MR only removed the message ID assignment but did _not_ remove the text altogether. On the other hand other messengers, including Telegram and WhatsApp, don't do this (they don't forward quotes together with messages). I argue that doing this is not expected by most users, and is bad for privacy. Forwarding a message should only forward that message, and not carry any more information. How I came to this: I was working on #8053 trying to undestand why the quoted message ID defaults to the last message of the target chat. And, thanks to 3f27be9, I questioned: "Why are we forwarding quotes in the first place?". So this also closes #8053. Note that this commit does not alter `quoted_message()`. That's for displaying old messages, and for compatibility with senders that do not remove the quote from forwarded messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6 commits, even commits are fixes, odd commits are tests. Reverting any fix breaks the corresponding test.
Merge with --no-ff to make testing easier.
Fixes #2839