Iroh share docs#3500
Merged
Merged
Conversation
r10s
commented
Jul 11, 2022
| body.to_string() | ||
| } else { | ||
| subject + "\n" + body | ||
| subject + "\n" + *body |
Contributor
Author
There was a problem hiding this comment.
i have no idea why this is needed, however, it fixes the clippy thingie from the iroh-share branch.
dignifiedquire
approved these changes
Jul 11, 2022
dignifiedquire
left a comment
dignifiedquire
left a comment
Collaborator
There was a problem hiding this comment.
thanks, looks great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dignifiedquire fixed a minor thing in repl and did a first round of documentation.
next step would be to implement dc_receive_backup(), however, feel free to merge this pr in between, i am afk for today and will probably continue not before tomorrow afternoon.