Skip to content

add dc_receive_backup ffi#3504

Merged
r10s merged 3 commits into
iroh-sharefrom
iroh-share-receive-ffi
Jul 13, 2022
Merged

add dc_receive_backup ffi#3504
r10s merged 3 commits into
iroh-sharefrom
iroh-share-receive-ffi

Conversation

@r10s

@r10s r10s commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

this pr adds the missing dc_reveive_backup() ffi.

i am failing in doing some rust tweaking to the spawn task; on cargo check in deltachat-ffi dir, currently there is the error ...

    Checking deltachat_ffi v1.89.0 (/Users/bpetersen/projects/deltachat-core-rust/deltachat-ffi)
error: generator cannot be sent between threads safely
    --> deltachat-ffi/src/lib.rs:2208:5
     |
2208 |     spawn(async move {
     |     ^^^^^ future created by async block is not `Send`
     |
     = help: the trait `Send` is not implemented for `dyn futures_core::stream::Stream<Item = Result<iroh_p2p::keys::Keypair, anyhow::Error>> + Unpin`
note: required by a bound in `spawn`
    --> deltachat-ffi/src/lib.rs:78:17
     |
76   | fn spawn<T>(fut: T) -> JoinHandle<T::Output>
     |    ----- required by a bound in this
77   | where
78   |     T: Future + Send + 'static,
     |                 ^^^^ required by this bound in `spawn`

error: could not compile `deltachat_ffi` due to previous error

... although the function seems to be quite similar to dc_imex() that has more or less the same behavior.

@r10s r10s changed the base branch from master to iroh-share July 13, 2022 11:36
@r10s r10s requested a review from dignifiedquire July 13, 2022 11:37
@r10s r10s merged commit f3c041d into iroh-share Jul 13, 2022
@r10s r10s deleted the iroh-share-receive-ffi branch July 13, 2022 12:44
dignifiedquire added a commit that referenced this pull request Jul 28, 2022
* add dc_receive_backup ffi

* fix compile issues

* make clippy happy

Co-authored-by: dignifiedquire <me@dignifiedquire.com>
dignifiedquire added a commit that referenced this pull request Aug 29, 2022
* add dc_receive_backup ffi

* fix compile issues

* make clippy happy

Co-authored-by: dignifiedquire <me@dignifiedquire.com>
dignifiedquire added a commit that referenced this pull request Aug 31, 2022
* add dc_receive_backup ffi

* fix compile issues

* make clippy happy

Co-authored-by: dignifiedquire <me@dignifiedquire.com>
dignifiedquire added a commit that referenced this pull request Sep 19, 2022
* add dc_receive_backup ffi

* fix compile issues

* make clippy happy

Co-authored-by: dignifiedquire <me@dignifiedquire.com>
dignifiedquire added a commit that referenced this pull request Oct 5, 2022
* add dc_receive_backup ffi

* fix compile issues

* make clippy happy

Co-authored-by: dignifiedquire <me@dignifiedquire.com>
dignifiedquire added a commit that referenced this pull request Nov 23, 2022
* add dc_receive_backup ffi

* fix compile issues

* make clippy happy

Co-authored-by: dignifiedquire <me@dignifiedquire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants