fix: do not sort prefetched messages by INTERNALDATE#8136
Merged
Conversation
link2xt
force-pushed
the
link2xt/no-internaldate-sorting
branch
from
90f56c7 to
cbe8aab
Compare
Messages are iterated over in fetch_new_msg_batch() and largest_uid_fetched variable is updated there assuming that messages come in the order of increasing UID. If UIDs are not increasing, it is possible that largest_uid_fetched will be updated even though smaller UID is not fetched yet and the message will be lost. INTERNALDATE sorting was introduced to deal with email providers such as Gmail that keep INTERNALDATE but not the UID order when moving the messages. Since we don't move the messages anymore after commit 04c0e7d, there is no need for ordering by INTERNALDATE.
link2xt
force-pushed
the
link2xt/no-internaldate-sorting
branch
from
cbe8aab to
b0985d9
Compare
iequidoo
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages are iterated over in fetch_new_msg_batch() and largest_uid_fetched variable is updated there
assuming that messages come in the order of increasing UID. If UIDs are not increasing, it is possible
that largest_uid_fetched will be updated
even though smaller UID is not fetched yet
and the message will be lost.
INTERNALDATE sorting was introduced to
deal with email providers such as Gmail
that keep INTERNALDATE but not the UID
order when moving the messages.
Since we don't move the messages anymore
after commit 04c0e7d, there is no need for ordering by INTERNALDATE.
Closes #7903