feat: allow sending webxdc update from broadcast subscribers#8139
feat: allow sending webxdc update from broadcast subscribers#8139
Conversation
cb6f887 to
19fd282
Compare
996877e to
33dbca1
Compare
iequidoo
left a comment
There was a problem hiding this comment.
So have you decided to not protect from "forwarding" subscribers' updates by the channel owner? Maybe confidentiality isn't a problem, but such forwarding may lead to bugs, see Hocuri's #7836 (review):
OTOH, it could be weird that the channel owner relays webxdc updates only if clicking "Resend" on the message; could lead to bugs.
|
Another problem is scalability: status updates acumulate over time, and the owner will resend all the status updates to new or even all the subscribers (if "Resend" is clicked). For broadcasts it will be worse than for groups, groups aren't large in general. |
|
tbh, i was not aware or forgot there is a pr hanging around already :) not resending updates at all, as in the old PR, will destroy many usecases of channels, so going for that seems to be over the top. so options are to (1) resend everything, maybe fine, or (2) to not resend updates from subscribers somehow. main point for (2) i also see to avoid tricking the channel owner's app to do weird things because of bugs, and to have fewer updates in general, so scalability |
33dbca1 to
1eef44e
Compare
|
I'd also go for (2), at least this way all subscribers will have the same set of status updates (i.e. owner's ones). My suggestion was to add a |
|
i try to sum up some discussion with @adbenitez @Amzd @link2xt - please add whatever i missed or remember wrong.
BUT:
as a summary, there was no final agreement but that |
The idea wasn't "this update belongs or made by X", but "this update was received from X" because at least in groups the app sender resends all the updates and also there were ideas to allow forwarding webxdc-s with all updates to the same chat in case if the app sender becomes unavailable. In fact in can be simplified to a bool column |
this PR allows channel subscribers send webxdc updates according to webxdc/website#137
the required webxdc info fields were already added at of #8138
closes #7679