Open
Conversation
r10s
force-pushed
the
r10s/improve-check-qr-doc
branch
from
d6f5901 to
86d035b
Compare
r10s
changed the title
r10s
force-pushed
the
r10s/improve-check-qr-doc
branch
from
86d035b to
7bd1429
Compare
adbenitez
reviewed
Apr 23, 2026
adbenitez
approved these changes
Apr 23, 2026
Co-authored-by: adb <asieldbenitez@gmail.com>
adbenitez
approved these changes
Apr 23, 2026
Hocuri
approved these changes
Apr 24, 2026
iequidoo
approved these changes
Apr 25, 2026
|
|
||
|
|
||
| /** | ||
| * Get QR code text that will offer an Setup-Contact or Verified-Group invitation. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Get QR code text (https:-link) that will offer an Setup-Contact or Verified-Group invitation. |
Otherwise only one paragraph in the middle says that an https:-link is returned, so it may be unclear which link is meant w/o reading all the paragraphs
| @@ -883,6 +883,8 @@ impl CommandApi { | |||
|
|
|||
| /// Get QR code text that will offer a [SecureJoin](https://securejoin.delta.chat/) invitation. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| /// Get QR code text that will offer a [SecureJoin](https://securejoin.delta.chat/) invitation. | |
| /// Get QR code text (https:-link) that will offer a [SecureJoin](https://securejoin.delta.chat/) invitation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds a hint about how to reset a QR code.
the API is as-is, just now, a refactoring here is also unwanted. the jsonrpc documentation needs to improved in general, this is known, and also not done by this PR
closes #7985