Skip to content

docs: Discourage into(), try_into() and parse()#8180

Merged
Hocuri merged 3 commits intomainfrom
hoc/update-syle-no-from
Apr 30, 2026
Merged

docs: Discourage into(), try_into() and parse()#8180
Hocuri merged 3 commits intomainfrom
hoc/update-syle-no-from

Conversation

@Hocuri
Copy link
Copy Markdown
Collaborator

@Hocuri Hocuri commented Apr 27, 2026

Follow-up to #8178 (comment)

I'm not completely sure if the note on the JsonRPC API (last paragraph) should be included.

@Hocuri Hocuri requested a review from link2xt April 27, 2026 09:20
Comment thread STYLE.md Outdated
which is hard to follow for people who are not familiar with Rust,
or who are not using rust-analyzer.

A notable exception is the Json-RPC API bindings,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A notable exception is the Json-RPC API bindings,
A notable exception is the JSON-RPC API bindings,

@link2xt
Copy link
Copy Markdown
Collaborator

link2xt commented Apr 27, 2026

I'm not completely sure if the note on the JsonRPC API (last paragraph) should be included.

Yes, can be just dropped.

@Hocuri Hocuri enabled auto-merge (squash) April 28, 2026 13:48
@Hocuri Hocuri disabled auto-merge April 28, 2026 13:49
@Hocuri Hocuri enabled auto-merge (squash) April 28, 2026 13:49
Copy link
Copy Markdown
Contributor

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@Hocuri Hocuri disabled auto-merge April 30, 2026 11:57
@Hocuri Hocuri merged commit 4b528e4 into main Apr 30, 2026
30 of 31 checks passed
@Hocuri Hocuri deleted the hoc/update-syle-no-from branch April 30, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants