fix: Fail receive_imf to not tombstone reaction if the referenced message isn't found#8181
Open
fix: Fail receive_imf to not tombstone reaction if the referenced message isn't found#8181
Conversation
Collaborator
|
Won't an error device message be added if receive_imf returns an Err? Seems unlikely that we want to do this whenever a reaction arrives early. |
iequidoo
force-pushed
the
iequidoo/dont-tombstone-orphaned-reaction
branch
from
ef2a1ba to
a47c8a4
Compare
Collaborator
Author
Decided to add some text-based error handling instead of complicating the receive_imf logic and added a check to the test. |
iequidoo
commented
Apr 28, 2026
| warn!(context, "receive_imf error: {err}."); | ||
| if !err.contains("(SKIP_DEVICE_MSG)") { | ||
| let text = format!( | ||
| "❌ Failed to receive a message: {err}. Core version v{DC_VERSION_STR}. Please report this bug to delta@merlinux.eu or https://support.delta.chat/", |
Collaborator
Author
There was a problem hiding this comment.
Removed "." from the end because Android displays it as a part of URL
…sage isn't found A reaction may arrive earler than the referenced message in case of multi-transport. By not creating a tombstone we still can receive it later on another transport.
…dc instance isn't found
…message isn't found
iequidoo
force-pushed
the
iequidoo/dont-tombstone-orphaned-reaction
branch
from
a47c8a4 to
e82f347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reaction may arrive earler than the referenced message in case of multi-transport. By not creating a tombstone we still can receive it later on another transport.
There are also the same fixes for Iroh-Node-Addr and Chat-Edit messages. Going to add corresponding tests if the approach is agreed.
Related to #7984