Conversation
Seems it was enabled by iroh and this is not the case with iroh 0.98. Better enable the feature explicitly since we directly use it.
f52e653 to
bf0b104
Compare
It is required for tokio::signal::ctrl_c
This is required by iroh 0.98.1
Had to precisely update pkcs8 to 0.11.0-rc.11, with 0.11.0-rc.12 ed25519 crate does not compile.
bf0b104 to
c9c05a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #7353, again checking what's the current state so we don't have to upgrade everything at once when Iroh 1.0 is released.