MimeFactory refactoring and fixes#8345
Draft
link2xt wants to merge 7 commits into
Draft
Conversation
link2xt
changed the title
link2xt
force-pushed
the
link2xt/last_added_location_timestamp
branch
4 times, most recently
from
45102bc to
1956c42
Compare
Stored location ID was not actually used and locations_last_sent timestamp was updated with the current time, possibly skipping locations.
… variable Pass it as a return value from Mimefactory.render_message instead of modifying self.last_added_location_timestamp in place.
…tiality Deciding whether to include the display name in the message is not a matter of header protection and should be decided when constructing the From header.
group_headers_by_confidentiality() can create unprotected versions of all headers in any case. If the message is not encrypted, protected original headers will be sent and unprotected headers will be thrown away.
link2xt
force-pushed
the
link2xt/last_added_location_timestamp
branch
from
d2042d4 to
ab2c000
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactoring PR in preparation for #8112.
It also contains fixes such as not rendering locations into pre-messages. They still need tests reproducing the bug.