build(deps-dev): vite 8 + vite-plugin-svelte 7 (supersedes #237, #239)#240
Merged
Conversation
The two dependabot PRs (#237, #239) each fail alone: plugin-svelte 6 peers on vite ^7 and plugin-svelte 7 peers on vite ^8, so the majors have to move together. Config migration for vite 8 (rolldown/oxc): - esbuild.drop no longer exists; prod console stripping and minification move to rolldown's oxc minifier via rollupOptions.output.minify (verified: 0 console.* calls in the minified prod bundle) - vite-plugin-svelte 7 removed the hot option (Svelte 5 HMR is automatic); it was already disabled under vitest
Deploying podnotes with
|
| Latest commit: |
9b2b0e7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3903c919.podnotes.pages.dev |
| Branch Preview URL: | https://deps-vite-8-plugin-svelte-7.podnotes.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines dependabot #237 (vite 8.1.3) and #239 (@sveltejs/vite-plugin-svelte 7.1.2), which are mutually dependent majors: plugin-svelte 6 peers on vite ^7 while plugin-svelte 7 peers on vite ^8, so each PR fails ERESOLVE alone. They only install together.
Config migration for the rolldown/oxc-based vite 8:
esbuild.dropis gone (the esbuild transform pipeline was replaced by oxc). Prod minification + console stripping now use rolldown's nativerollupOptions.output.minifywithcompress.dropConsole. Verified empirically: prodmain.jsis minified/mangled and contains 0console.*calls, matching the old behavior.hotoption (Svelte 5 HMR is automatic); dropped from vitest.config.ts where it was already forced off under vitest.Verification: lint, biome, typecheck, build, svelte-check, 876/876 unit tests green; plugin reloaded in live Obsidian (dev vault) with the oxc-minified bundle - loads clean, API + protocol handler registered, no console errors. E2E runtime tests pass (the live-playback ones flake under full-suite load on the local machine regardless of branch - known harness/transport issue, each passes individually).
Note: oxc-minified bundle is 411 kB vs 406 kB with esbuild - negligible.
Closes #237
Closes #239