chore(deps): drop no-op node-gyp undici override#241
Merged
Conversation
node-gyp only exists as a bundled dependency inside the npm package, where overrides cannot reach; the fix that actually resolved its vendored undici was re-resolving npm to 11.18.0. Flagged by Devin review on #229. Lockfile is byte-identical without the override, confirming it was inert.
Deploying podnotes with
|
| Latest commit: |
75745bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8c5d7056.podnotes.pages.dev |
| Branch Preview URL: | https://chore-remove-noop-override.podnotes.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #229. Devin's review correctly noted the node-gyp override is inert: node-gyp only exists bundled inside the npm package, where npm overrides cannot reach. The vendored-undici advisory was actually fixed by re-resolving npm to 11.18.0, so the override never did anything.
Removing it changes nothing in the lockfile (verified:
npm installreports up to date,npm auditstill 0 vulnerabilities). The @actions/http-client override stays - that one is live and pins undici 6.27.0 under a real unbundled dep.