fix(orca): invoke the runner via the worktree-local bin in the archive hook#285
Merged
Conversation
…e hook Orca runs hooks with a non-login GUI PATH where the npm shim is often absent, so `npm exec obsidian-e2e` could fail and be swallowed by `|| true`, leaking the worktree's Obsidian instance. The local node_modules/.bin launcher is POSIX sh and needs only node, which the existing guard already checks. Mirrors quickadd ca29a8a7.
Deploying podnotes with
|
| Latest commit: |
ce31569
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a5426bb9.podnotes.pages.dev |
| Branch Preview URL: | https://fix-orca-hook-local-bin.podnotes.pages.dev |
Owner
Author
|
All CI checks are green (Test, CodeQL, Analyze x2, Cloudflare Pages, Graphite AI Reviews). No open review threads and no changes requested. Verified the one-line orca.yaml change locally: the worktree-local launcher |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #283. Orca runs lifecycle hooks with a non-login GUI PATH where the npm shim is often absent, so the archive hook's
npm exec obsidian-e2e -- stopcould fail and be silently swallowed by|| true, leaking the worktree's Obsidian process tree and /tmp profile.The hook now calls the worktree-local
node_modules/.bin/obsidian-e2edirectly. That launcher is POSIX sh and needs onlynode, which the existingcommand -v nodeguard already checks. Verified under a cleanenv -i PATH=/usr/bin:/bin:<node dir>environment: the bin resolves and performs the stop (dry-run).Same fix already landed in quickadd (ca29a8a7) and metaedit after a Codex review flagged it there.
Housekeeping note: this commit was originally pushed to the #283 branch in a race with its merge (the push recreated the just-auto-deleted branch); that stray branch has been deleted and this PR carries the fix cleanly on master.