Skip to content

feat(logging): improve error message & add link to Node errors page. #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chimurai merged 3 commits into from
Sep 1, 2016
Merged

feat(logging): improve error message & add link to Node errors page. #106

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9614dd0
feat(logging): add error description when logging errors.
cloudmu Aug 30, 2016
8be5919
feat(logging): remove errno dependency & add link to Node errors page.
cloudmu Aug 30, 2016
a465761
feat(logging) remove line-break in error log.
cloudmu Sep 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,10 @@ function HttpProxyMiddleware(context, opts) {
}

function logError(err, req, res) {
var hostname = (req.hostname || req.host) || (req.headers && req.headers.host); // (node0.10 || node 4/5) || (websocket)
var targetUri = (proxyOptions.target.host || proxyOptions.target) + req.url;
var hostname = (req.headers && req.headers.host) || (req.hostname || req.host); // (websocket) || (node0.10 || node 4/5)
var target = proxyOptions.target.host || proxyOptions.target;
var errReference = 'https://nodejs.org/api/errors.html#errors_common_system_errors'; // link to Node Common Systems Errors page

logger.error('[HPM] PROXY ERROR: %s. %s -> %s', err.code, hostname, targetUri);
logger.error('[HPM] Error occurred while trying to proxy request %s from %s to %s (%s) (%s)', req.url, hostname, target, err.code, errReference);
}
Copy link
Copy Markdown

@gaearon gaearon Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need HPM here? If this is a transitive dependency people will be confused what it means.

};