Deduplicate directory entries in readdir for shared driver parent paths#52
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix duplicated dmgpio8 directories
Deduplicate directory entries in May 27, 2026
readdir for shared driver parent paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple
dmgpiosection configurations can resolve to the same parent directory (e.g./dmgpio8/), causingreaddir("/")to emit duplicate directory names (dmgpio8twice). This PR updates directory iteration so each immediate subdirectory is returned once per listing pass.Root cause
readdiradvanced one driver at a time and emitted directory names derived from parent paths without collapsing consecutive entries mapping to the same immediate subdirectory.Change in directory iteration
_readdir, after emitting a directory entry, iteration now skips subsequent driver nodes that would produce the sameread_next_subdir_name(...)result for the current listing path.Scope
src/dmdevfs.c(_readdirflow), no API or path-format changes.