Open
Conversation
Member
|
Would be cool to run these with tape-run; initial test are looking good!
…On Sun, Jul 9, 2017 at 9:42 PM Johnny Hauser ***@***.***> wrote:
Here's some tests! They might be awful, but it's a start. I don't think
it's possible to test whether timing is disabled without wrapping
everything in an extra function, then module.exports =
require('./that-function')(). It would be good to do something so that
the feature detection can be refreshed for the sake of testing. Meanwhile,
the disabled tests are skipped.
------------------------------
You can view, comment on, or merge this pull request online at:
#8
Commit Summary
- added tests, "disable" tests are skipped for now
File Changes
- *A* test.js
<https://github.com/choojs/nanotiming/pull/8/files#diff-0> (62)
Patch Links:
- https://github.com/choojs/nanotiming/pull/8.patch
- https://github.com/choojs/nanotiming/pull/8.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWleonPyhkldnwhTYgEkXHQ02klYGmuks5sMS0ygaJpZM4OSKaK>
.
|
Member
|
Heya, are you still interested in landing this PR? Think we're pretty close; just needs the finishing touch and we'd be good to go! :D |
Contributor
Author
|
Oops. I forgot about this. I added in |
Member
|
fixed conflict and added xvfb on travis so tape-run doesn't quit instantly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's some tests! They might be awful, but it's a start. I don't think it's possible to test whether timing is disabled without wrapping everything in an extra function, then
module.exports = require('./that-function')(). It would be good to do something so that the feature detection can be refreshed for the sake of testing. Meanwhile, thedisabledtests are skipped.