Claude/connect branch 012 dw yg mqz bs g5 vu9 zueq lyz

[chpeu]

PR Type

Enhancement, Bug fix, Tests

---

Description

• Implement WebSocket reconnection callback to resubscribe to monitored symbols

• Add protection against WebSocket updates during active trading positions

• Fix price formatting inconsistency by changing 'tickSize' to 'tick_size'

• Add comprehensive test coverage for dashboard routes, MEXC API, and PostgreSQL logger

• Fix test failures and improve database connection handling

---

Diagram Walkthrough

flowchart LR
  WS["WebSocket Manager"] -->|reconnect_callback| PR["Price Provider"]
  PR -->|resubscribe_after_reconnect| WS
  PR -->|monitored_symbols| Storage["Symbol Storage"]
  Scanner["Scanner Loop"] -->|check active_position| Guard["Position Guard"]
  Guard -->|prevent update| Scalability["Scalability Refresh"]
  Position["Position Manager"] -->|tick_size| Frontend["Frontend API"]
  Tests["Test Suite"] -->|coverage| Coverage["88%+ Coverage"]

Loading

File Walkthrough

	Relevant files
Enhancement	4 files price_provider.py Add WebSocket reconnection callback and symbol resubscription +68/-8    reliability.py Add reconnect callback support to WebSocket manager            +11/-0    scanner_loop.py Restart WebSocket for single position symbol monitoring    +16/-0    main.py Refactor WebSocket management for position-specific monitoring +32/-16
Bug fix	3 files scalability_refresh.py Prevent WebSocket updates during active positions                +12/-3    position_manager.py Change tickSize to tick_size for consistency                          +1/-1      postgresql_datalogger.py Initialize pool to None when psycopg2 unavailable                +1/-0
Tests	4 files test_dashboard_routes.py Add comprehensive dashboard routes test coverage                  +320/-0  test_mexc.py Add comprehensive MEXC API client test coverage                    +355/-0  test_postgresql_datalogger.py Skip obsolete tests and fix connection handling                    +9/-7      test_simple_pg_logger.py Add comprehensive PostgreSQL logger test coverage                +518/-0

---

[qodo-code-review]

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Missing audit: New critical actions like restarting WebSocket on position open are not explicitly logged with user/context metadata, making audit reconstruction unclear. Referred Code # Ceci garantit que current_price sera mis à jour correctement pendant la position if _price_provider: try: # Arrêter WebSocket actuel if hasattr(_price_provider, 'stop_websocket'): await _price_provider.stop_websocket() logger.debug("🔌 WebSocket arrêté pour position") # Redémarrer WebSocket uniquement sur le symbole de la position if hasattr(_price_provider, 'start_websocket'): await _price_provider.start_websocket([symbol]) logger.info(f"✅ WebSocket redémarré pour position: {symbol} uniquement") except Exception as e: logger.error(f"❌ Erreur redémarrage WebSocket pour position: {e}") Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Broad except: Broad exception handlers without contextual details (e.g., in _resubscribe_after_reconnect) may hide actionable diagnostics and skip specific edge cases. Referred Code except Exception as e: logger.error(f"❌ Erreur réabonnement WebSocket: {e}") Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Unvalidated input: The new resubscription flow trusts symbols from state without explicit validation or sanitization before subscribing to WebSocket channels. Referred Code for symbol in symbols_to_subscribe: await self.ws_manager.subscribe_ticker(symbol) await asyncio.sleep(0.05) # Petit délai Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Refactor duplicated code into a helper Refactor the duplicated WebSocket restart logic from core/callbacks/scanner_loop.py and main.py into a single reusable helper function to improve maintainability. core/callbacks/scanner_loop.py [417-431] # 🔥 FIX: Redémarrer WebSocket UNIQUEMENT sur le symbole de la position # Ceci garantit que current_price sera mis à jour correctement pendant la position +# NOTE: This logic should be moved to a shared utility function to avoid duplication. +# Example: await restart_websocket_for_position(symbol, _price_provider) if _price_provider: try: # Arrêter WebSocket actuel if hasattr(_price_provider, 'stop_websocket'): await _price_provider.stop_websocket() logger.debug("🔌 WebSocket arrêté pour position") # Redémarrer WebSocket uniquement sur le symbole de la position if hasattr(_price_provider, 'start_websocket'): await _price_provider.start_websocket([symbol]) logger.info(f"✅ WebSocket redémarré pour position: {symbol} uniquement") except Exception as e: logger.error(f"❌ Erreur redémarrage WebSocket pour position: {e}") Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly identifies duplicated logic for restarting the WebSocket in core/callbacks/scanner_loop.py and main.py and proposes a valid refactoring to improve maintainability.	Low
Update