Claude/connect branch 012 dw yg mqz bs g5 vu9 zueq lyz

[chpeu]

PR Type

Enhancement, Bug fix, Tests

---

Description

• Implement WebSocket reconnection callback to resubscribe to monitored symbols after connection loss

• Fix price formatting inconsistency by changing tickSize to tick_size in position data

• Prevent WebSocket updates during active positions to maintain price stability

• Add comprehensive test coverage for dashboard routes, MEXC API, and PostgreSQL logger

• Improve frontend price formatting using significant decimals from entry price

---

Diagram Walkthrough

flowchart LR
  WS["WebSocket Manager"] -->|reconnect_callback| PR["Price Provider"]
  PR -->|resubscribe| WS
  PR -->|monitored_symbols| RECON["Reconnection Logic"]
  RECON -->|check active_position| SCANNER["Scanner Loop"]
  SCANNER -->|restart WS| PR
  SCALABILITY["Scalability Refresh"] -->|check position| PR
  FRONTEND["Frontend PositionCard"] -->|getSignificantDecimals| FORMAT["Format Utils"]
  FORMAT -->|formatWithoutTrailingZeros| DISPLAY["Price Display"]

Loading

File Walkthrough

	Relevant files
Enhancement	6 files price_provider.py Add WebSocket reconnection callback and symbol resubscription +68/-8    reliability.py Add reconnect_callback attribute to WebSocketManager          +11/-0    scanner_loop.py Restart WebSocket with only position symbol when opening position +16/-0    main.py Restart WebSocket for position symbol and add double position check +32/-16  PositionCard.svelte Use significant decimals from entry price for formatting  +19/-15  format.js Add functions for significant decimal calculation and formatting +57/-0
Bug fix	3 files scalability_refresh.py Prevent WebSocket updates during active positions                +12/-3    position_manager.py Change tickSize to tick_size for Python naming convention +1/-1      postgresql_datalogger.py Initialize pool to None when psycopg2 unavailable                +1/-0
Tests	4 files test_dashboard_routes.py Add comprehensive test suite for dashboard API routes        +320/-0  test_mexc.py Add comprehensive test suite for MEXC API client                  +355/-0  test_postgresql_datalogger.py Skip obsolete tests and fix connection pool initialization +9/-7      test_simple_pg_logger.py Add comprehensive test suite for PostgreSQL logger              +518/-0

---

[qodo-code-review]

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Action Logging: New critical actions like restarting WebSocket on position open and scalability refresh do not clearly add structured audit logs with user/context, making audit trail completeness uncertain. Referred Code # 🔥 FIX CRITIQUE: Redémarrer WebSocket UNIQUEMENT sur le symbole de la position # Ceci garantit que current_price sera mis à jour correctement pendant la position # PROBLÈME: subscribe_ticker() ajoutait juste le symbole aux symboles existants # SOLUTION: Redémarrer complètement le WebSocket avec UNIQUEMENT le symbole de la position if price_provider: try: # Arrêter WebSocket actuel if hasattr(price_provider, 'stop_websocket'): await price_provider.stop_websocket() logger.info(f"🔌 WebSocket arrêté avant position") # Redémarrer WebSocket uniquement sur le symbole de la position if hasattr(price_provider, 'start_websocket'): await price_provider.start_websocket([symbol]) logger.info(f"✅ WebSocket redémarré pour position: {symbol} UNIQUEMENT") # Configurer callback pour suivre position active if hasattr(price_provider, 'set_socketio_callback'): price_provider.set_socketio_callback(None, symbol) logger.debug(f"📡 WebSocket configuré pour suivre {symbol} (prix en temps réel dans cache)") except Exception as e: ... (clipped 1 lines) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Weak Exception: Broad exception handling during reconnection resubscribe logs only the error message without actionable context about symbols or state, which may hinder debugging. Referred Code except Exception as e: logger.error(f"❌ Erreur réabonnement WebSocket: {e}") Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Input Validation: Formatting helpers accept values without explicit validation or type checks beyond isNaN, which may be insufficient if external inputs reach these functions. Referred Code export function getSignificantDecimals(value) { if (value === null || value === undefined || isNaN(value)) { return 2; } const str = value.toString(); // If no decimal point, return 0 if (!str.includes('.')) { return 0; } // Get decimal part const decimalPart = str.split('.')[1]; // Remove trailing zeros const withoutTrailingZeros = decimalPart.replace(/0+$/, ''); // Return length (number of significant decimals) return withoutTrailingZeros.length; } Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
High-level	Simplify WebSocket subscription management logic Instead of stopping and restarting the WebSocket to change symbol subscriptions, manage them dynamically. Use subscribe and unsubscribe commands on a single, persistent connection to simplify logic and reduce errors. Examples: core/callbacks/scanner_loop.py [417-431] # 🔥 FIX: Redémarrer WebSocket UNIQUEMENT sur le symbole de la position # Ceci garantit que current_price sera mis à jour correctement pendant la position if _price_provider: try: # Arrêter WebSocket actuel if hasattr(_price_provider, 'stop_websocket'): await _price_provider.stop_websocket() logger.debug("🔌 WebSocket arrêté pour position") # Redémarrer WebSocket uniquement sur le symbole de la position ... (clipped 5 lines) main.py [898-919] # 🔥 FIX CRITIQUE: Redémarrer WebSocket UNIQUEMENT sur le symbole de la position # Ceci garantit que current_price sera mis à jour correctement pendant la position # PROBLÈME: subscribe_ticker() ajoutait juste le symbole aux symboles existants # SOLUTION: Redémarrer complètement le WebSocket avec UNIQUEMENT le symbole de la position if price_provider: try: # Arrêter WebSocket actuel if hasattr(price_provider, 'stop_websocket'): await price_provider.stop_websocket() logger.info(f"🔌 WebSocket arrêté avant position") ... (clipped 12 lines) Solution Walkthrough: Before: # In scanner_loop.py / main.py (when opening a position) async def open_position(symbol): # ... # Stop the entire WebSocket connection await price_provider.stop_websocket() # Restart the WebSocket with only the single active symbol await price_provider.start_websocket([symbol]) # ... # In scalability_refresh.py async def _update_websocket(top_pairs): # Check if a position is active to avoid restarting if position_manager.active_position: return # Stop and restart WebSocket with new pairs await _price_provider.stop_websocket() await _price_provider.start_websocket(new_symbols) After: # In a centralized subscription manager (e.g., price_provider.py) class PriceProvider: async def set_active_subscriptions(self, symbols_to_monitor): current_symbols = self.monitored_symbols symbols_to_add = set(symbols_to_monitor) - set(current_symbols) symbols_to_remove = set(current_symbols) - set(symbols_to_monitor) for symbol in symbols_to_remove: await self.ws_manager.unsubscribe_ticker(symbol) for symbol in symbols_to_add: await self.ws_manager.subscribe_ticker(symbol) self.monitored_symbols = symbols_to_monitor # In scanner_loop.py / main.py (when opening a position) await price_provider.set_active_subscriptions([position_symbol]) # In scalability_refresh.py await price_provider.set_active_subscriptions(new_top_pairs_symbols) Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies that the PR's method of stopping and restarting the WebSocket to manage subscriptions is complex and brittle, and proposes a more robust architectural solution using subscribe/unsubscribe commands, which would simplify logic across multiple files.	High
Possible issue	Initialize all instance attributes In the PostgreSQLDataLogger constructor, initialize scan_buffer, opportunity_buffer, and flush_thread within the if not PSYCOPG2_AVAILABLE: block to prevent potential AttributeErrors. core/postgresql_datalogger.py [187-191] if not PSYCOPG2_AVAILABLE: logger.error("❌ psycopg2 non disponible - PostgreSQL DataLogger désactivé") self.enabled = False self.pool = None + self.scan_buffer = deque() + self.opportunity_buffer = deque() + self.flush_thread = None return Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies that several instance attributes are not initialized if psycopg2 is unavailable, which could lead to an AttributeError, and proposes initializing them to default values for robustness.	Low
General	Simplify active position detection logic Simplify the active position detection logic by first checking position_manager.active_position and then falling back to app_state.get('active_position') to avoid redundancy. api/price_provider.py [220-231] # 🔥 FIX: Vérifier via app_state pour détecter position active from main import app_state, position_manager -if app_state and (app_state.get('active_position') or ( - position_manager and position_manager.active_position -)): + +active_pos = None +if position_manager and position_manager.active_position: + active_pos = position_manager.active_position +elif app_state and app_state.get('active_position'): + active_pos = app_state.get('active_position') + +if active_pos: # Position active: réabonner UNIQUEMENT au symbole de la position - active_pos = position_manager.active_position if position_manager else app_state.get('active_position') - if active_pos: - position_symbol = active_pos.symbol if hasattr(active_pos, 'symbol') else active_pos.get('symbol') - if position_symbol: - symbols_to_subscribe = [position_symbol] - logger.info(f"🔄 Réabonnement WebSocket (position active): {position_symbol} UNIQUEMENT") + position_symbol = active_pos.symbol if hasattr(active_pos, 'symbol') else active_pos.get('symbol') + if position_symbol: + symbols_to_subscribe = [position_symbol] + logger.info(f"🔄 Réabonnement WebSocket (position active): {position_symbol} UNIQUEMENT") Apply / Chat Suggestion importance[1-10]: 4 __ Why: The suggestion proposes a valid refactoring that simplifies the logic for finding the active position, making the code more readable and less redundant.	Low
Update