Claude/fix multiple errors 011 c uycb zyp8 u3cuy4 hyln wy

[chpeu]

PR Type

Enhancement, Bug fix

---

Description

• Complete WebSocket native migration with Socket.IO removal

• Implement configuration persistence system with backup management

• Add multi-client synchronization via config_change broadcast

• Add bot reboot functionality with automatic frontend reload

---

Diagram Walkthrough

flowchart LR
  A["Frontend Config Change"] -->|WebSocket| B["Backend update_config"]
  B -->|Save| C["ConfigPersistence"]
  C -->|JSON File + Backups| D["config/trading_config.json"]
  B -->|Broadcast| E["config_change Event"]
  E -->|All Clients| F["VariablesPanel Update"]
  G["Bot Reboot"] -->|WebSocket| H["bot_rebooting Event"]
  H -->|Auto Reload| I["Frontend Refresh"]
  J["Startup"] -->|Load| C
  C -->|Restore| K["TRADING_CONFIG"]

Loading

File Walkthrough

	Relevant files
Enhancement	5 files config_persistence.py New configuration persistence layer with backups                  +232/-0  main.py Add config persistence and reboot command support                +59/-5    BotControls.svelte Add reboot bot button with user confirmation                          +69/-3    SettingsPanel.svelte Add config_change event listener for bidirectional sync    +22/-1    VariablesPanel.svelte Implement real-time config synchronization listener            +28/-5
Bug fix	2 files +page.svelte Simplify WebSocket initialization and add config_change handler +22/-40  socket.js Remove legacy Socket.IO wrapper completely                              +0/-245
Documentation	3 files ANALYSE_WEBSOCKET_COMPLET.md Comprehensive WebSocket analysis and architecture documentation +632/-0  BUGS_CRITIQUES.md Document 8 critical bugs with reproduction steps and solutions +424/-0  SYNTHESE_COMPOSANTS.md Component usage matrix and parameter synchronization reference +314/-0
Dependencies	2 files package.json Remove socket.io-client dependency                                              +1/-2      requirements.txt Remove python-socketio and python-engineio dependencies    +0/-2

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🔴	Unauthenticated reboot Description: The 'reboot_bot' command allows any connected WebSocket client to trigger a full backend process restart via os.execv without authentication or authorization controls, enabling trivial denial of service. main.py [2378-2397] Referred Code elif command == 'reboot_bot': # 🔥 REBOOT: Redémarrer le bot (backend + frontend via HMR) logger.warning("🔄 Redémarrage du bot demandé...") await add_log('WARNING', 'Redémarrage du bot', 'Redémarrage demandé par l\'utilisateur') # Broadcaster aux clients pour qu'ils se préparent if ws_manager: await ws_manager.emit('bot_rebooting', { 'message': 'Bot redémarrage dans 2 secondes...', 'timestamp': time.time() }) # Attendre un peu pour que le message soit envoyé await asyncio.sleep(2) # Redémarrer le processus Python import os import sys logger.info("🔄 Exécution du redémarrage...") os.execv(sys.executable, ['python'] + sys.argv)
⚪	Unauthenticated config change Description: Configuration change broadcasts and saves can be triggered by any WebSocket client without authentication or rate limiting, allowing unauthorized tampering with trading parameters. main.py [2355-2361] Referred Code # 🔥 BIDIRECTIONNEL: Broadcaster les changements à tous les clients if ws_manager: await ws_manager.emit('config_change', { 'changes': updated, 'timestamp': time.time() })
	Insecure file storage Description: Configuration backups are created and old backups deleted without file permission hardening or path validation, potentially exposing sensitive trading settings if file system permissions are permissive. config_persistence.py [37-66] Referred Code # Créer une sauvegarde de la config actuelle si elle existe if self.config_file.exists(): timestamp = int(time.time()) backup_file = self.backup_dir / f"config_backup_{timestamp}.json" self.config_file.rename(backup_file) # Garder seulement les 10 dernières sauvegardes self._cleanup_old_backups(keep=10) # Sauvegarder la nouvelle config config_data = { 'config': config, 'timestamp': time.time(), 'version': '7.0.0' } # Écrire dans un fichier temporaire d'abord temp_file = self.config_file.with_suffix('.tmp') with open(temp_file, 'w', encoding='utf-8') as f: json.dump(config_data, f, indent=2, ensure_ascii=False) ... (clipped 9 lines)
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Missing audit logging: Critical actions like configuration updates and reboot requests are logged without user identity and with limited structured context, making audit trails incomplete. Referred Code if updated: logger.info(f"✅ Config mise à jour via WebSocket: {updated}") await add_log('INFO', 'Config mise à jour', str(updated)) # 🔥 BIDIRECTIONNEL: Broadcaster les changements à tous les clients if ws_manager: await ws_manager.emit('config_change', { 'changes': updated, 'timestamp': time.time() }) # 🔥 BUG FIX #1: Sauvegarder la configuration après mise à jour try: config_persistence = get_config_persistence() config_persistence.save(TRADING_CONFIG) logger.debug("💾 Configuration sauvegardée automatiquement") except Exception as e: logger.error(f"❌ Erreur sauvegarde configuration: {e}") return {'updated': updated, 'success': True} ... (clipped 28 lines) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Reboot error handling: The 'reboot_bot' command performs os.execv without validating prerequisites or providing fallback/confirmation handling if the exec fails beyond a generic exception path. Referred Code elif command == 'reboot_bot': # 🔥 REBOOT: Redémarrer le bot (backend + frontend via HMR) logger.warning("🔄 Redémarrage du bot demandé...") await add_log('WARNING', 'Redémarrage du bot', 'Redémarrage demandé par l\'utilisateur') # Broadcaster aux clients pour qu'ils se préparent if ws_manager: await ws_manager.emit('bot_rebooting', { 'message': 'Bot redémarrage dans 2 secondes...', 'timestamp': time.time() }) # Attendre un peu pour que le message soit envoyé await asyncio.sleep(2) # Redémarrer le processus Python import os import sys logger.info("🔄 Exécution du redémarrage...") os.execv(sys.executable, ['python'] + sys.argv) ... (clipped 1 lines) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Error detail exposure: Logger messages include raw exception strings which may leak filesystem paths or internal details if surfaced to end-users; ensure these are confined to internal logs only. Referred Code except Exception as e: logger.error(f"❌ Erreur sauvegarde configuration: {e}") return False Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Unstructured logs: Logs are free-form strings with emojis rather than structured entries, and may include file paths; consider using structured logging and ensure no sensitive config values are logged. Referred Code logger.info(f"✅ Configuration sauvegardée: {self.config_file}") return True except Exception as e: logger.error(f"❌ Erreur sauvegarde configuration: {e}") return False def load(self) -> Optional[Dict[str, Any]]: """ Charger la configuration Returns: Dictionnaire de configuration ou None si erreur """ try: if not self.config_file.exists(): logger.info("ℹ️ Aucune configuration sauvegardée trouvée") return None with open(self.config_file, 'r', encoding='utf-8') as f: config_data = json.load(f) ... (clipped 50 lines) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Command input trust: WebSocket commands like 'reboot_bot' and 'update_config' accept client parameters without visible authentication/authorization checks in the diff, which may allow unauthorized changes. Referred Code # 🔥 BIDIRECTIONNEL: Broadcaster les changements à tous les clients if ws_manager: await ws_manager.emit('config_change', { 'changes': updated, 'timestamp': time.time() }) # 🔥 BUG FIX #1: Sauvegarder la configuration après mise à jour try: config_persistence = get_config_persistence() config_persistence.save(TRADING_CONFIG) logger.debug("💾 Configuration sauvegardée automatiquement") except Exception as e: logger.error(f"❌ Erreur sauvegarde configuration: {e}") return {'updated': updated, 'success': True} elif command == 'get_status': status_data = app_state.copy() if status_data.get('active_position') and hasattr(status_data['active_position'], 'to_dict'): status_data['active_position'] = status_data['active_position'].to_dict() ... (clipped 24 lines) Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
High-level	Re-evaluate the "reboot bot" feature The "reboot bot" feature should be changed. Instead of using os.execv to restart the process from within the application, it should gracefully shut down and let an external process manager like Docker or systemd handle the restart. Examples: main.py [2378-2400] elif command == 'reboot_bot': # 🔥 REBOOT: Redémarrer le bot (backend + frontend via HMR) logger.warning("🔄 Redémarrage du bot demandé...") await add_log('WARNING', 'Redémarrage du bot', 'Redémarrage demandé par l\'utilisateur') # Broadcaster aux clients pour qu'ils se préparent if ws_manager: await ws_manager.emit('bot_rebooting', { 'message': 'Bot redémarrage dans 2 secondes...', 'timestamp': time.time() ... (clipped 13 lines) frontend/src/lib/components/BotControls.svelte [65-93] async function rebootBot() { if (!confirm('⚠️ Redémarrer le bot (backend + frontend) ?\n\nCela arrêtera toutes les opérations en cours.')) { return; } try { rebooting = true; const ws = initWebSocket(); if (ws && ws.connected) { ... (clipped 19 lines) Solution Walkthrough: Before: # main.py async def handle_client_command(command: str, params: dict): # ... elif command == 'reboot_bot': logger.warning("🔄 Redémarrage du bot demandé...") await ws_manager.emit('bot_rebooting', ...) await asyncio.sleep(2) # Restart the process using os.execv import os import sys os.execv(sys.executable, ['python'] + sys.argv) After: # main.py async def handle_client_command(command: str, params: dict): # ... elif command == 'reboot_bot': logger.warning("🔄 Arrêt du bot demandé pour redémarrage...") await ws_manager.emit('bot_stopping_for_reboot', ...) await asyncio.sleep(1) # Gracefully stop the server # The external process manager (systemd, Docker) will handle the restart. uvicorn_server.should_exit = True # or sys.exit(RESTART_EXIT_CODE) Suggestion importance[1-10]: 9 __ Why: This suggestion correctly identifies a significant architectural flaw in the new reboot_bot feature, as using os.execv is brittle and bypasses standard process management, posing a high risk to application stability.	High
Possible issue	Avoid race condition on WebSocket initialization In the onMount hook, instead of using a fixed setTimeout to wait for the WebSocket connection, set up listeners based on the connection status. If already connected, set them up immediately; otherwise, use the ws.on('connect', ...) event to ensure listeners are attached reliably. frontend/src/routes/+page.svelte [67-94] // Fetch initial state on mount onMount(async () => { // 🔥 MIGRATION COMPLÈTE: Initialiser WebSocket natif try { const ws = initWebSocket(); // Vérifier que l'instance est correcte if (!ws) { console.error('❌ WebSocket instance est null'); return; } - // Attendre que la connexion soit établie - await new Promise(resolve => setTimeout(resolve, 500)); - - // Setup listeners - if (ws && typeof ws.on === 'function') { + // Setup listeners once connected + if (ws.connected) { setupWebSocketListeners(ws); } else { - console.error('❌ WebSocket.on n\'est pas disponible'); + ws.on('connect', () => { + setupWebSocketListeners(ws); + }); } } catch (error) { console.error('❌ Erreur initialisation WebSocket:', error); } // Charger l'état initial (via REST pour le premier chargement, puis WebSocket pour les updates) await loadInitialState(); }); [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a race condition caused by a fixed timeout and proposes a more robust, event-driven approach, which significantly improves the reliability of WebSocket event handling.	Medium
	Copy backup file instead of moving In the _restore_from_backup function, use shutil.copy() instead of replace() to copy the backup file. This preserves the backup for future use instead of consuming it during the restoration process. core/config_persistence.py [100-131] def _restore_from_backup(self) -> Optional[Dict[str, Any]]: """ Restaurer depuis la sauvegarde la plus récente Returns: Dictionnaire de configuration ou None si aucune sauvegarde """ try: # Trouver la sauvegarde la plus récente backups = sorted(self.backup_dir.glob("config_backup_*.json"), reverse=True) if not backups: logger.warning("⚠️ Aucune sauvegarde disponible") return None latest_backup = backups[0] logger.info(f"🔄 Restauration depuis sauvegarde: {latest_backup.name}") with open(latest_backup, 'r', encoding='utf-8') as f: config_data = json.load(f) config = config_data.get('config', {}) # Copier la sauvegarde comme config actuelle - latest_backup.replace(self.config_file) + import shutil + shutil.copy(latest_backup, self.config_file) logger.info(f"✅ Configuration restaurée depuis sauvegarde") return config except Exception as e: logger.error(f"❌ Erreur restauration depuis sauvegarde: {e}") return None Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly identifies that moving the backup file is destructive and proposes a safer copy operation, which improves the robustness of the new configuration recovery feature.	Low
	Fix button getting stuck in disabled state In the rebootBot function, reset the rebooting flag to false within the else block that handles a disconnected WebSocket. This prevents the reboot button from getting stuck in a disabled state. frontend/src/lib/components/BotControls.svelte [65-93] async function rebootBot() { if (!confirm('⚠️ Redémarrer le bot (backend + frontend) ?\n\nCela arrêtera toutes les opérations en cours.')) { return; } try { rebooting = true; const ws = initWebSocket(); if (ws && ws.connected) { await ws.sendCommand('reboot_bot'); console.log('🔄 Bot redémarrage en cours...'); // Afficher un message pendant le redémarrage alert('🔄 Bot en cours de redémarrage...\n\nLa page se rechargera automatiquement dans quelques secondes.'); // Recharger la page après 5 secondes setTimeout(() => { window.location.reload(); }, 5000); } else { alert('❌ WebSocket non connecté. Impossible de redémarrer le bot.'); + rebooting = false; } } catch (err) { console.error('❌ Error rebooting bot:', err); alert('❌ Erreur lors du redémarrage du bot.'); rebooting = false; } } Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies a UI bug where a button becomes permanently disabled and provides the correct fix, improving the usability of the new reboot feature.	Low
General	Implement a more graceful server reboot In the reboot_bot command handler, replace the os.execv call with raise uvicorn.Server.ShouldExit to trigger a graceful shutdown. This allows uvicorn to handle the restart process cleanly, especially in development with --reload. main.py [2378-2399] elif command == 'reboot_bot': # 🔥 REBOOT: Redémarrer le bot (backend + frontend via HMR) logger.warning("🔄 Redémarrage du bot demandé...") await add_log('WARNING', 'Redémarrage du bot', 'Redémarrage demandé par l\'utilisateur') # Broadcaster aux clients pour qu'ils se préparent if ws_manager: await ws_manager.emit('bot_rebooting', { 'message': 'Bot redémarrage dans 2 secondes...', 'timestamp': time.time() }) # Attendre un peu pour que le message soit envoyé await asyncio.sleep(2) - # Redémarrer le processus Python - import os - import sys + # Redémarrer le processus Python de manière plus propre logger.info("🔄 Exécution du redémarrage...") - os.execv(sys.executable, ['python'] + sys.argv) + try: + import uvicorn + raise uvicorn.Server.ShouldExit + except (ImportError, AttributeError): + # Fallback pour les environnements où uvicorn n'est pas directement accessible + import os + import sys + os.execv(sys.executable, ['python'] + sys.argv) return {'status': 'rebooting', 'message': 'Bot redémarrage...'} Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion proposes a more graceful server shutdown method that integrates with the uvicorn lifecycle, which is a significant improvement over the abrupt os.execv call.	Medium
Update

[qodo-code-review]

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: test

Failed stage: Run tests with coverage [❌]

Failed test name: TestFastAPIWebSocketEndpoint::test_concurrent_config_updates_with_lock

Failure summary: The action failed due to missing dependency jinja2, required by Starlette's Jinja2Templates initialization in main.py. - When tests imported from main import app, module-level code executed: templates = Jinja2Templates(directory="templates") (main.py:174). - This raised AssertionError: jinja2 must be installed to use Jinja2Templates from starlette/templating.py:73. - As a result, multiple tests in tests/test_fastapi_websocket_endpoint.py errored during setup, and one test failed for the same reason. - Representative traceback lines: - tests/test_fastapi_websocket_endpoint.py:20 -> import app - main.py:174 -> Jinja2Templates(...) - starlette/templating.py:73 -> AssertionError about missing jinja2.

Relevant error logs: 1: ##[group]Runner Image Provisioner 2: Hosted Compute Agent ... 68: hint: Disable this message with "git config set advice.defaultBranchName false" 69: Initialized empty Git repository in /home/runner/work/test/test/.git/ 70: [command]/usr/bin/git remote add origin https://github.com/chpeu/test 71: ##[endgroup] 72: ##[group]Disabling automatic garbage collection 73: [command]/usr/bin/git config --local gc.auto 0 74: ##[endgroup] 75: ##[group]Setting up auth 76: [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand 77: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :" 78: [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader 79: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :" 80: [command]/usr/bin/git config --local http.https://github.com/.extraheader AUTHORIZATION: basic *** 81: ##[endgroup] 82: ##[group]Fetching the repository 83: [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +92c026bd1867509699cd84d215b568f79e64bfa6:refs/remotes/origin/claude/fix-multiple-errors-011CUycbZyp8U3cuy4HYLNWy 84: remote: Enumerating objects: 473, done. ... 400: Resolving deltas: 42% (9/21) 401: Resolving deltas: 47% (10/21) 402: Resolving deltas: 52% (11/21) 403: Resolving deltas: 57% (12/21) 404: Resolving deltas: 61% (13/21) 405: Resolving deltas: 66% (14/21) 406: Resolving deltas: 71% (15/21) 407: Resolving deltas: 76% (16/21) 408: Resolving deltas: 80% (17/21) 409: Resolving deltas: 85% (18/21) 410: Resolving deltas: 90% (19/21) 411: Resolving deltas: 95% (20/21) 412: Resolving deltas: 100% (21/21) 413: Resolving deltas: 100% (21/21), done. 414: From https://github.com/chpeu/test 415: * [new ref] 92c026bd1867509699cd84d215b568f79e64bfa6 -> origin/claude/fix-multiple-errors-011CUycbZyp8U3cuy4HYLNWy 416: ##[endgroup] 417: ##[group]Determining the checkout info 418: ##[endgroup] 419: ##[group]Checking out the ref 420: [command]/usr/bin/git checkout --progress --force -B claude/fix-multiple-errors-011CUycbZyp8U3cuy4HYLNWy refs/remotes/origin/claude/fix-multiple-errors-011CUycbZyp8U3cuy4HYLNWy 421: Switched to a new branch 'claude/fix-multiple-errors-011CUycbZyp8U3cuy4HYLNWy' 422: branch 'claude/fix-multiple-errors-011CUycbZyp8U3cuy4HYLNWy' set up to track 'origin/claude/fix-multiple-errors-011CUycbZyp8U3cuy4HYLNWy'. 423: ##[endgroup] ... 652: ============================= test session starts ============================== 653: platform linux -- Python 3.11.14, pytest-7.4.3, pluggy-1.6.0 -- /opt/hostedtoolcache/Python/3.11.14/x64/bin/python 654: cachedir: .pytest_cache 655: rootdir: /home/runner/work/test/test 656: configfile: pytest.ini 657: plugins: anyio-3.7.1, asyncio-0.21.1, cov-4.1.0 658: asyncio: mode=Mode.STRICT 659: collecting ... collected 326 items 660: tests/test_analyzer_refactored.py::test_import_analyzer_modules PASSED [ 0%] 661: tests/test_analyzer_refactored.py::test_filters PASSED [ 0%] 662: tests/test_analyzer_refactored.py::test_signal_generator PASSED [ 0%] 663: tests/test_analyzer_refactored.py::test_scoring PASSED [ 1%] 664: tests/test_analyzer_refactored.py::test_risk_detector PASSED [ 1%] 665: tests/test_analyzer_refactored.py::test_technical_analyzer_init PASSED [ 1%] 666: tests/test_api_modules.py::TestMEXCAPI::test_fetch_ticker_success SKIPPEDes correctement) [ 2%] 667: tests/test_api_modules.py::TestMEXCAPI::test_fetch_ticker_error SKIPPEDes correctement) [ 2%] 668: tests/test_api_modules.py::TestMEXCAPI::test_fetch_tickers_success SKIPPEDes correctement) [ 2%] 669: tests/test_api_modules.py::TestMEXCAPI::test_fetch_tickers_error SKIPPEDes correctement) [ 3%] 670: tests/test_api_modules.py::TestMEXCAPI::test_fetch_ohlcv_success SKIPPEDes correctement) [ 3%] 671: tests/test_api_modules.py::TestMEXCAPI::test_fetch_ohlcv_error SKIPPEDses correctement) [ 3%] 672: tests/test_api_modules.py::TestMEXCAPI::test_fetch_order_book_success SKIPPEDes correctement) [ 3%] 673: tests/test_api_modules.py::TestMEXCAPI::test_fetch_order_book_error SKIPPEDes correctement) [ 4%] 674: tests/test_api_modules.py::TestMEXCAPI::test_fetch_funding_rate_success SKIPPEDes correctement) [ 4%] 675: tests/test_api_modules.py::TestMEXCAPI::test_fetch_funding_rate_not_found SKIPPEDes correctement) [ 4%] 676: tests/test_api_modules.py::TestMEXCAPI::test_fetch_funding_rate_error SKIPPEDes correctement) [ 5%] 677: tests/test_api_modules.py::TestMEXCAPI::test_get_mexc_client_singleton SKIPPEDes correctement) [ 5%] 678: tests/test_api_modules.py::TestPriceProvider::test_get_current_price_cached SKIPPED [ 5%] 679: tests/test_api_modules.py::TestPriceProvider::test_get_current_price_error SKIPPED [ 6%] 680: tests/test_api_modules.py::TestPriceProvider::test_get_multiple_prices SKIPPED [ 6%] 681: tests/test_api_modules.py::TestReliabilityManager::test_fetch_with_retry_success_first_try SKIPPEDrefactoriser) [ 6%] 682: tests/test_api_modules.py::TestReliabilityManager::test_fetch_with_retry_success_after_retry SKIPPEDrefactoriser) [ 7%] 683: tests/test_api_modules.py::TestReliabilityManager::test_fetch_with_retry_all_failed SKIPPEDrefactoriser) [ 7%] 684: tests/test_api_modules.py::TestReliabilityManager::test_fetch_with_all_protections_success SKIPPEDrefactoriser) [ 7%] 685: tests/test_api_modules.py::TestReliabilityManager::test_fetch_with_timeout SKIPPEDrefactoriser) [ 7%] 686: tests/test_async_modules.py::TestMarketDataAsync::test_check_spread_success_excellent PASSED [ 8%] 687: tests/test_async_modules.py::TestMarketDataAsync::test_check_spread_cached PASSED [ 8%] 688: tests/test_async_modules.py::TestMarketDataAsync::test_check_spread_too_wide PASSED [ 8%] 689: tests/test_async_modules.py::TestMarketDataAsync::test_check_spread_empty_orderbook PASSED [ 9%] 690: tests/test_async_modules.py::TestMarketDataAsync::test_check_spread_error_handling PASSED [ 9%] 691: tests/test_async_modules.py::TestMarketDataAsync::test_check_spread_atr_mode PASSED [ 9%] ... 694: tests/test_async_modules.py::TestMarketDataAsync::test_check_orderbook_imbalance_cached PASSED [ 10%] 695: tests/test_async_modules.py::TestMarketDataAsync::test_check_orderbook_imbalance_none_orderbook PASSED [ 11%] 696: tests/test_async_modules.py::TestMarketDataAsync::test_check_orderbook_imbalance_empty_bids_asks PASSED [ 11%] 697: tests/test_async_modules.py::TestCorrelationAsync::test_check_static_correlation_disabled PASSED [ 11%] 698: tests/test_async_modules.py::TestCorrelationAsync::test_check_static_correlation_no_active_positions PASSED [ 11%] 699: tests/test_async_modules.py::TestCorrelationAsync::test_check_static_correlation_no_group PASSED [ 12%] 700: tests/test_async_modules.py::TestCorrelationAsync::test_check_static_correlation_hard_mode_reject PASSED [ 12%] 701: tests/test_async_modules.py::TestCorrelationAsync::test_check_static_correlation_soft_mode_penalty PASSED [ 12%] 702: tests/test_async_modules.py::TestCorrelationAsync::test_check_dynamic_correlation_disabled PASSED [ 13%] 703: tests/test_async_modules.py::TestCorrelationAsync::test_check_dynamic_correlation_no_filter PASSED [ 13%] 704: tests/test_async_modules.py::TestCorrelationAsync::test_check_dynamic_correlation_with_penalty PASSED [ 13%] 705: tests/test_async_modules.py::TestScannerAsync::test_calculate_volatility PASSED [ 14%] 706: tests/test_async_modules.py::TestScannerAsync::test_calculate_volatility_insufficient_data PASSED [ 14%] 707: tests/test_async_modules.py::TestScannerAsync::test_fetch_spread_data_success PASSED [ 14%] 708: tests/test_async_modules.py::TestScannerAsync::test_fetch_spread_data_empty_orderbook PASSED [ 15%] 709: tests/test_async_modules.py::TestScannerAsync::test_fetch_spread_data_error PASSED [ 15%] 710: tests/test_async_modules.py::TestScannerAsync::test_calculate_score_valid PASSED [ 15%] 711: tests/test_async_modules.py::TestScannerAsync::test_calculate_score_high_spread PASSED [ 15%] 712: tests/test_async_modules.py::TestScannerAsync::test_calculate_score_low_volume PASSED [ 16%] 713: tests/test_async_modules.py::TestScannerAsync::test_scan_pair_success PASSED [ 16%] 714: tests/test_async_modules.py::TestScannerAsync::test_scan_pair_insufficient_klines PASSED [ 16%] 715: tests/test_async_modules.py::TestScannerAsync::test_scan_pair_error PASSED [ 17%] 716: tests/test_async_modules.py::TestAnalyticsDatabase::test_init_database PASSED [ 17%] 717: tests/test_async_modules.py::TestAnalyticsDatabase::test_insert_rejected_setup PASSED [ 17%] 718: tests/test_async_modules.py::TestAnalyticsDatabase::test_get_rejected_setups PASSED [ 18%] 719: tests/test_async_modules.py::TestAnalyticsDatabase::test_get_rejection_summary PASSED [ 18%] 720: tests/test_async_modules.py::TestAnalyticsDatabase::test_insert_validated_setup PASSED [ 18%] 721: tests/test_async_modules.py::TestAnalyticsDatabase::test_insert_trade PASSED [ 19%] 722: tests/test_async_modules.py::TestAnalyticsDatabase::test_get_trades PASSED [ 19%] 723: tests/test_async_modules.py::TestAnalyticsDatabase::test_insert_trade_behavior PASSED [ 19%] 724: tests/test_async_modules.py::TestAnalyticsDatabase::test_get_trade_behavior PASSED [ 19%] 725: tests/test_async_modules.py::TestAnalyticsDatabase::test_get_global_stats PASSED [ 20%] 726: tests/test_async_modules.py::TestAnalyticsDatabase::test_get_analytics_db_helper PASSED [ 20%] 727: tests/test_async_modules.py::TestCallbacksAsync::test_scanner_loop_callback_no_instances PASSED [ 20%] 728: tests/test_async_modules.py::TestCallbacksAsync::test_scanner_loop_callback_with_active_position PASSED [ 21%] 729: tests/test_async_modules.py::TestCallbacksAsync::test_scan_pair_for_setup_no_analyzer PASSED [ 21%] 730: tests/test_async_modules.py::TestCallbacksAsync::test_scan_pair_for_setup_success PASSED [ 21%] 731: tests/test_async_modules.py::TestCallbacksAsync::test_scan_pair_for_setup_error PASSED [ 22%] 732: tests/test_config_manager.py::TestConfigManager::test_atomic_write PASSED [ 22%] ... 772: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_pnl_percent_short PASSED [ 34%] 773: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_pnl_percent_invalid_entry PASSED [ 34%] 774: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_pnl_usdt_basic PASSED [ 35%] 775: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_pnl_usdt_with_partial_tp PASSED [ 35%] 776: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_pnl_usdt_with_partial_tp_no_size_remaining PASSED [ 35%] 777: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_realized_pnl_basic PASSED [ 36%] 778: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_realized_pnl_with_partial_tp PASSED [ 36%] 779: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_realized_pnl_short PASSED [ 36%] 780: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_realized_pnl_loss PASSED [ 37%] 781: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_costs_basic PASSED [ 37%] 782: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_costs_no_slippage PASSED [ 37%] 783: tests/test_edge_cases.py::TestPnLCalculatorEdgeCases::test_calculate_costs_high_fees PASSED [ 38%] 784: tests/test_edge_cases.py::TestRecoveryModeEdgeCases::test_recovery_mode_activation PASSED [ 38%] 785: tests/test_edge_cases.py::TestRecoveryModeEdgeCases::test_recovery_mode_deactivation PASSED [ 38%] 786: tests/test_edge_cases.py::TestRecoveryModeEdgeCases::test_recovery_mode_position_size_reduction PASSED [ 38%] 787: tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_websocket_connection_and_initial_status ERROR [ 39%] 788: tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_update_config_command_with_valid_params ERROR [ 39%] 789: tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_update_config_command_with_invalid_params ERROR [ 39%] 790: tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_ping_pong_heartbeat ERROR [ 40%] 791: tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_concurrent_config_updates_with_lock FAILED [ 40%] 792: tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_subscribe_unsubscribe_channels ERROR [ 40%] 793: tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_get_state_request ERROR [ 41%] 794: tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_log_config_command_with_validation ERROR [ 41%] 795: tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_unknown_command_error ERROR [ 41%] 796: tests/test_indicators_comprehensive.py::TestEMA::test_calculate_ema_basic PASSED [ 42%] ... 971: tests/test_websocket_manager.py::TestWebSocketManager::test_send_config_change PASSED [ 95%] 972: tests/test_websocket_manager.py::TestWebSocketManager::test_ping_all PASSED [ 96%] 973: tests/test_websocket_manager.py::TestGetWebSocketManager::test_singleton_returns_same_instance PASSED [ 96%] 974: tests/test_websocket_manager.py::TestGetWebSocketManager::test_instance_is_websocket_manager PASSED [ 96%] 975: tests/test_websocket_manager.py::TestWebSocketIntegration::test_multiple_clients_receive_broadcast PASSED [ 96%] 976: tests/test_websocket_manager.py::TestWebSocketIntegration::test_room_isolation PASSED [ 97%] 977: tests/test_websocket_manager.py::TestWebSocketIntegration::test_concurrent_operations PASSED [ 97%] 978: tests/test_websocket_manager_integration.py::TestWebSocketManagerIntegration::test_connect_and_disconnect PASSED [ 97%] 979: tests/test_websocket_manager_integration.py::TestWebSocketManagerIntegration::test_multiple_connections PASSED [ 98%] 980: tests/test_websocket_manager_integration.py::TestWebSocketManagerIntegration::test_broadcast_to_multiple_clients PASSED [ 98%] 981: tests/test_websocket_manager_integration.py::TestWebSocketManagerIntegration::test_emit_event_to_all_clients PASSED [ 98%] 982: tests/test_websocket_manager_integration.py::TestWebSocketManagerIntegration::test_task_tracking_and_cancellation PASSED [ 99%] 983: tests/test_websocket_manager_integration.py::TestWebSocketManagerIntegration::test_rooms_subscription_and_emit PASSED [ 99%] 984: tests/test_websocket_manager_integration.py::TestWebSocketManagerIntegration::test_send_personal_message PASSED [ 99%] 985: tests/test_websocket_manager_integration.py::TestWebSocketManagerIntegration::test_broadcast_with_disconnected_client PASSED [100%] 986: ==================================== ERRORS ==================================== 987: _ ERROR at setup of TestFastAPIWebSocketEndpoint.test_websocket_connection_and_initial_status _ 988: tests/test_fastapi_websocket_endpoint.py:20: in client 989: from main import app 990: main.py:174: in <module> 991: templates = Jinja2Templates(directory="templates") 992: /opt/hostedtoolcache/Python/3.11.14/x64/lib/python3.11/site-packages/starlette/templating.py:73: in __init__ 993: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" 994: E AssertionError: jinja2 must be installed to use Jinja2Templates 995: _ ERROR at setup of TestFastAPIWebSocketEndpoint.test_update_config_command_with_valid_params _ 996: tests/test_fastapi_websocket_endpoint.py:20: in client 997: from main import app 998: main.py:174: in <module> 999: templates = Jinja2Templates(directory="templates") 1000: /opt/hostedtoolcache/Python/3.11.14/x64/lib/python3.11/site-packages/starlette/templating.py:73: in __init__ 1001: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" 1002: E AssertionError: jinja2 must be installed to use Jinja2Templates 1003: _ ERROR at setup of TestFastAPIWebSocketEndpoint.test_update_config_command_with_invalid_params _ 1004: tests/test_fastapi_websocket_endpoint.py:20: in client 1005: from main import app 1006: main.py:174: in <module> 1007: templates = Jinja2Templates(directory="templates") 1008: /opt/hostedtoolcache/Python/3.11.14/x64/lib/python3.11/site-packages/starlette/templating.py:73: in __init__ 1009: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" 1010: E AssertionError: jinja2 must be installed to use Jinja2Templates 1011: ___ ERROR at setup of TestFastAPIWebSocketEndpoint.test_ping_pong_heartbeat ____ 1012: tests/test_fastapi_websocket_endpoint.py:20: in client 1013: from main import app 1014: main.py:174: in <module> 1015: templates = Jinja2Templates(directory="templates") 1016: /opt/hostedtoolcache/Python/3.11.14/x64/lib/python3.11/site-packages/starlette/templating.py:73: in __init__ 1017: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" 1018: E AssertionError: jinja2 must be installed to use Jinja2Templates 1019: _ ERROR at setup of TestFastAPIWebSocketEndpoint.test_subscribe_unsubscribe_channels _ 1020: tests/test_fastapi_websocket_endpoint.py:20: in client 1021: from main import app 1022: main.py:174: in <module> 1023: templates = Jinja2Templates(directory="templates") 1024: /opt/hostedtoolcache/Python/3.11.14/x64/lib/python3.11/site-packages/starlette/templating.py:73: in __init__ 1025: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" 1026: E AssertionError: jinja2 must be installed to use Jinja2Templates 1027: ____ ERROR at setup of TestFastAPIWebSocketEndpoint.test_get_state_request _____ 1028: tests/test_fastapi_websocket_endpoint.py:20: in client 1029: from main import app 1030: main.py:174: in <module> 1031: templates = Jinja2Templates(directory="templates") 1032: /opt/hostedtoolcache/Python/3.11.14/x64/lib/python3.11/site-packages/starlette/templating.py:73: in __init__ 1033: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" 1034: E AssertionError: jinja2 must be installed to use Jinja2Templates 1035: _ ERROR at setup of TestFastAPIWebSocketEndpoint.test_log_config_command_with_validation _ 1036: tests/test_fastapi_websocket_endpoint.py:20: in client 1037: from main import app 1038: main.py:174: in <module> 1039: templates = Jinja2Templates(directory="templates") 1040: /opt/hostedtoolcache/Python/3.11.14/x64/lib/python3.11/site-packages/starlette/templating.py:73: in __init__ 1041: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" 1042: E AssertionError: jinja2 must be installed to use Jinja2Templates 1043: __ ERROR at setup of TestFastAPIWebSocketEndpoint.test_unknown_command_error ___ 1044: tests/test_fastapi_websocket_endpoint.py:20: in client 1045: from main import app 1046: main.py:174: in <module> 1047: templates = Jinja2Templates(directory="templates") 1048: /opt/hostedtoolcache/Python/3.11.14/x64/lib/python3.11/site-packages/starlette/templating.py:73: in __init__ 1049: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" 1050: E AssertionError: jinja2 must be installed to use Jinja2Templates 1051: =================================== FAILURES =================================== 1052: ____ TestFastAPIWebSocketEndpoint.test_concurrent_config_updates_with_lock _____ 1053: tests/test_fastapi_websocket_endpoint.py:189: in test_concurrent_config_updates_with_lock 1054: from main import _config_lock, UpdateConfigParams 1055: main.py:174: in <module> 1056: templates = Jinja2Templates(directory="templates") 1057: /opt/hostedtoolcache/Python/3.11.14/x64/lib/python3.11/site-packages/starlette/templating.py:73: in __init__ 1058: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" 1059: E AssertionError: jinja2 must be installed to use Jinja2Templates 1060: ---------- coverage: platform linux, python 3.11.14-final-0 ---------- ... 1094: core/position/early_invalidation.py 52 4 92.31% 57, 101, 117, 137 1095: core/position/partial_tp_manager.py 39 2 94.87% 42, 77 1096: core/position/pnl_calculator.py 68 6 91.18% 63, 82-83, 193-196 1097: core/position/recovery_mode.py 59 9 84.75% 54, 57-65, 101, 152-155 1098: core/position/tp_escalier_manager.py 54 6 88.89% 56, 63, 76-77, 88, 124 1099: core/position/tp_sl_calculator.py 111 34 69.37% 86, 101-130, 168-169, 173-174, 191-192, 200-202, 208-210, 225, 227, 262 1100: core/position/trailing_stop.py 45 3 93.33% 72, 85, 124 1101: core/position_manager.py 290 75 74.14% 171, 174-180, 300, 303, 354-370, 492-511, 536-542, 546-555, 608-626, 634-637, 644-652, 666, 672-693, 711, 729, 785-786, 828 1102: core/scanner.py 121 48 60.33% 64, 76, 101, 191, 204-289, 293 1103: core/scheduler.py 91 75 17.58% 21-29, 33, 37, 41, 45-54, 58-68, 72-81, 85-104, 108-126, 130-151 1104: core/websocket_manager.py 143 27 81.12% 63-64, 80-82, 87, 116, 148, 152, 156, 160, 168, 172, 176, 195-197, 202, 239-241, 253-260 1105: ---------------------------------------------------------------------- 1106: TOTAL 4363 2104 51.78% 1107: Coverage XML written to file coverage.xml 1108: =========================== short test summary info ============================ 1109: FAILED tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_concurrent_config_updates_with_lock - AssertionError: jinja2 must be installed to use Jinja2Templates 1110: ERROR tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_websocket_connection_and_initial_status - AssertionError: jinja2 must be installed to use Jinja2Templates 1111: ERROR tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_update_config_command_with_valid_params - AssertionError: jinja2 must be installed to use Jinja2Templates 1112: ERROR tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_update_config_command_with_invalid_params - AssertionError: jinja2 must be installed to use Jinja2Templates 1113: ERROR tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_ping_pong_heartbeat - AssertionError: jinja2 must be installed to use Jinja2Templates 1114: ERROR tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_subscribe_unsubscribe_channels - AssertionError: jinja2 must be installed to use Jinja2Templates 1115: ERROR tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_get_state_request - AssertionError: jinja2 must be installed to use Jinja2Templates 1116: ERROR tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_log_config_command_with_validation - AssertionError: jinja2 must be installed to use Jinja2Templates 1117: ERROR tests/test_fastapi_websocket_endpoint.py::TestFastAPIWebSocketEndpoint::test_unknown_command_error - AssertionError: jinja2 must be installed to use Jinja2Templates 1118: ======= 1 failed, 297 passed, 20 skipped, 29 warnings, 8 errors in 7.61s ======= 1119: ##[error]Process completed with exit code 1. 1120: Post job cleanup.