Skip to content

Added typescript definition, corrected README - #10

Merged
chrvadala merged 4 commits into
chrvadala:masterfrom
pascalopitz:master
Dec 13, 2020
Merged

Added typescript definition, corrected README#10
chrvadala merged 4 commits into
chrvadala:masterfrom
pascalopitz:master

Conversation

@pascalopitz

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

coveralls commented Jun 21, 2020

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.779% when pulling cfcaf20 on pascalopitz:master into 99bbf70 on chrvadala:master.

@pascalopitz
pascalopitz force-pushed the master branch 2 times, most recently from bc044a7 to 18461f5 Compare June 21, 2020 05:34

@chrvadala chrvadala left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your PR. below some comments

@pascalopitz

Copy link
Copy Markdown
Contributor Author

No worries. Good work on the lib, works a treat!

@chrvadala

Copy link
Copy Markdown
Owner

Thank you, I'll merge soon

@chrvadala chrvadala self-assigned this Jun 21, 2020
@Sunoo

Sunoo commented Aug 30, 2020

Copy link
Copy Markdown
Contributor

Just a quick note, spotted a few mismatches between this type definition and the library, and I corrected them in a pull request on that fork: pascalopitz#1

Might make sense to look into that before merging.

@jordanorc

Copy link
Copy Markdown

Any update on that?

@chrvadala
chrvadala merged commit a12407a into chrvadala:master Dec 13, 2020
@chrvadala

Copy link
Copy Markdown
Owner

Released with v1.3.0
Thanks @pascalopitz for the PR

@jordanorc

Copy link
Copy Markdown

Thank's @chrvadala and @pascalopitz! Great work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants