Added typescript definition, corrected README - #10
Conversation
bc044a7 to
18461f5
Compare
chrvadala
left a comment
There was a problem hiding this comment.
thanks for your PR. below some comments
-
Since this library uses yarn.lock, can you remove package-lock.json file?
(anyway do not update yarn.lock, I will update it before releasing) -
can you add tsc check? see following links
https://github.com/chrvadala/transformation-matrix/blob/f63b78816b1f89f5632392fc59d46aed8175830a/package.json#L30
https://github.com/chrvadala/transformation-matrix/blob/f63b78816b1f89f5632392fc59d46aed8175830a/package.json#L20
|
No worries. Good work on the lib, works a treat! |
|
Thank you, I'll merge soon |
|
Just a quick note, spotted a few mismatches between this type definition and the library, and I corrected them in a pull request on that fork: pascalopitz#1 Might make sense to look into that before merging. |
Corrections
|
Any update on that? |
|
Released with v1.3.0 |
|
Thank's @chrvadala and @pascalopitz! Great work :) |
No description provided.