add writeValueWithoutResponse and writeValueWithResponse methods - #47
Merged
Conversation
Contributor
Author
|
Hi @chrvadala, thanks for the quick reply. I have now added tests. |
chrvadala
approved these changes
Nov 2, 2022
Owner
|
Thanks @derwehr, I will merge and publish in a couple days. Thanks a lot |
Owner
|
I released this PR with 1.9.0 and I added your name into contributions list. |
dmarku
added a commit
to dmarku/node-ble
that referenced
this pull request
Nov 14, 2023
…WithResponse` methods Add type declarations for the methods `writeValueWithoutResponse` and `writeValueWithResponse` that were added to `GattCharacteristic` with chrvadala#47
nmasse-itix
pushed a commit
to Demo-AI-Edge-Crazy-Train/node-ble
that referenced
this pull request
Apr 29, 2024
… `writeValueWithResponse` (chrvadala#63) * add type declarations for `writeValueWithoutResponse` and `writeValueWithResponse` methods Add type declarations for the methods `writeValueWithoutResponse` and `writeValueWithResponse` that were added to `GattCharacteristic` with chrvadala#47 * Fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebBluetooth specs deprecated
writeValue(). So I addedwriteValueWithoutResponseandwriteValueWithResponseto be back on par with the spec