Pre-requisites - #68
Merged
Merged
Conversation
- Move the compatibility section to the top. - Explicitly mention that Windows and Mac OS are not supported - Mention `apt` install
chrvadala
reviewed
Apr 14, 2024
| - Debian | ||
|
|
||
| ```sh | ||
| sudo apt install dbus bluetooth bluez libbluetooth-dev libudev-dev |
Owner
There was a problem hiding this comment.
Are you sure that all these dependencies are needed? Usually I don't install them on ubuntu, but maybe that on debian something could be different.
Can you double check?
Contributor
Author
There was a problem hiding this comment.
Based on #31 (comment) - but its hard to tell with the setup I have it has a mix of docker and external debian packages that it uses
Contributor
Author
There was a problem hiding this comment.
Note that its not just Debian, its in a docker node:18-slim container so has any regular packages removed.
chrvadala
requested changes
Apr 14, 2024
chrvadala
left a comment
chrvadala
left a comment
Owner
There was a problem hiding this comment.
Thanks for this PR. I added a comment
Closed
chrvadala
approved these changes
May 19, 2024
Owner
|
Released with v1.11. Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarification for #31.
To prevent frustration for Windows/Mac OS users, I moved the compatibility section to the top and added
aptinstall requirements.aptinstall