Skip to content

test(lightspeed): locale-aware MCP settings e2e (panel + configure token) - #3

Merged
ciiay merged 3 commits into
ciiay:rhidp-12079-mcp-token-config-2from
HusneShabbir:fix/lightspeed-e2e-menu-locators-on-2708
Apr 10, 2026
Merged

test(lightspeed): locale-aware MCP settings e2e (panel + configure token)#3
ciiay merged 3 commits into
ciiay:rhidp-12079-mcp-token-config-2from
HusneShabbir:fix/lightspeed-e2e-menu-locators-on-2708

Conversation

@HusneShabbir

@HusneShabbir HusneShabbir commented Apr 10, 2026

Copy link
Copy Markdown

Configure MCP server token (e2e)

Automates the “configure server” dialog for MCP personal access tokens (PAT) under mocked /api/lightspeed/mcp-servers data. Assertions use translations / formatMcpToolCountStatus so they match the active locale.

Test What it checks
Valid token saves — Overlay Row starts as token required → open edit → enter valid test token → save → PAT field hides → row shows tool count after mock PATCH/validate (5 tools).
Invalid then valid — Dock to window Bad token → invalid credentials message → good token → saves → row shows tools.
Cancel — Fullscreen Enter draft token → Cancel → modal closes → row still token required (nothing saved).
Server validation failure — Overlay Mock forces POST …/validate to fail for this server → after valid PAT, UI shows validation failed (localized). User can cancel and leave.
Missing server URL — Dock to window Server has no URL → valid PAT + save → cannot validate without URL message (localized).
Clear PAT — Fullscreen Type text → use clear on the field → input empty and hint restored → cancel out.

Note:
Each case runs in a different chatbot layout (Overlay / Dock / Fullscreen) to cover the dialog in those modes.
Also fixed the broken e2e from redhat-developer#2708

Resolves:
https://redhat.atlassian.net/browse/RHIDP-11788

- Query MCP and pinned menu items from page scope for visibility

Made-with: Cursor
… skip

Wire MCP page objects and tests to lightspeed mcp.settings.* (and modal.*)
strings via getTranslations. Add helpers for selected count and tool status
text. Extend mock validate options with failServerValidateError. Remove
skipUnlessLocales for Chatbot MCP settings; keep per-test navigation.

Made-with: Cursor
@HusneShabbir
HusneShabbir force-pushed the fix/lightspeed-e2e-menu-locators-on-2708 branch from 7757d29 to 5273e1d Compare April 10, 2026 10:04
@HusneShabbir HusneShabbir changed the title fix(lightspeed): stabilize display mode menu e2e locators test(lightspeed): locale-aware MCP settings e2e (panel + configure token) Apr 10, 2026
Comment thread workspaces/lightspeed/packages/app-legacy/e2e-tests/utils/devMode.ts Outdated
Comment thread workspaces/lightspeed/packages/app-legacy/e2e-tests/utils/devMode.ts Outdated
Comment thread workspaces/lightspeed/packages/app-legacy/e2e-tests/fixtures/mcpServerMocks.ts Outdated
Comment thread workspaces/lightspeed/packages/app-legacy/e2e-tests/fixtures/mcpServerMocks.ts Outdated
Comment thread workspaces/lightspeed/packages/app-legacy/e2e-tests/fixtures/mcpServerMocks.ts Outdated
- mcpServerMocks: inline status detail logic; derive selected count without
  getDisplayStatusForMock
- devMode: single POST validate payload; PATCH mutates server in place

Made-with: Cursor
@HusneShabbir
HusneShabbir requested a review from jrichter1 April 10, 2026 12:54
@jrichter1

Copy link
Copy Markdown

looks fine, just make sure the workflows run green

@ciiay
ciiay merged commit a750e6e into ciiay:rhidp-12079-mcp-token-config-2 Apr 10, 2026
ciiay pushed a commit that referenced this pull request Jul 15, 2026
… capabilities (redhat-developer#3703)

* chore(boost): RHDHPLAN-1505 feasibility analysis wrt current upstream capabilities

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: gabemontero <gmontero@redhat.com>

* fix(boost): address review-agent terminology findings in feasibility reports

- apply(entity, params) → apply(resource, params) to match Backstage API
- '16 lifecycle permissions' → '16 entity permissions' to match codebase
- 'Boost admin panel' → augment workspace with path for implementers

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(boost): RHDHPLAN-1505 update feasibility reports per RBAC plugin capabilities

Update RHDHPLAN-1508 feasibility report:
- Correct 5 capabilities from 'Not available' to 'Partially available'
  based on verified RBAC plugin source code
- Add RBACProvider and AuditorService as new capability rows
- Add Option C (RBACProvider-based policy sync) as recommended approach
  for RHIDP-15274 cascade
- Revise complexity: Cascade High→Medium, Default-Deny Medium→Low-Medium,
  Audit Medium→Low, Admin UI Medium-High→Medium
- Rewrite Key Findings: 7 points reflecting actual RBAC capabilities

Update RHDHPLAN-1507 feasibility report:
- Clarify catalog EventsService status: infrastructure exists but only
  publishes experimental.catalog.conflict and experimental.catalog.errors,
  NOT entity lifecycle events
- Update comparison table: RHDHPLAN-1508 column revised downward

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(boost): RHDHPLAN-1505 update feasibility reports for Jira epic consolidation

Update all 4 feasibility reports to reflect the 6 epics closed during
Jira consolidation (2026-07-08):

- RHDHPLAN-1507: Mark RHIDP-15254, 15261, 15263, 15267 as closed with
  consolidation banners showing where scope was absorbed
- RHDHPLAN-1508: Update RHIDP-15277 and Key Finding 4 to reflect
  RHIDP-15333 closure and consolidation
- RHDHPLAN-1510: Mark RHIDP-15315 as closed (absorbed into 15294),
  update RHIDP-15316 to note absorbed air-gapped scope
- RHDHPLAN-1513: Mark RHIDP-15333 as closed (absorbed into 15277)

All summary matrices now include Status column. Cross-report comparison
tables corrected: RHDHPLAN-1508 deviations 3→1, overall epic count
22→16 active. Key findings updated across all reports.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(boost): RHDHPLAN-1505 update feasibility reports for stakeholder alignment

Cross-validate RHDHPLAN-1505 stakeholder meeting agreements (2026-07-13)
against feasibility reports for RHDHPLAN-1507, 1508, 1510, 1513.

RHDHPLAN-1507 updates:
- Add RHDHPLAN-1113 dependency for entity kind mappings (Boost refrains
  from defining new catalog entity mappings)
- If RHDHPLAN-1113 lands before RHIDP-15258, SDK adopts AIResource
  mappings directly with no temporary Resource/Component mapping
- MCP resource mapping deferred for RHDH 2.1
- Add RHDHPLAN-404 entity schema dependency context
- Update Key Findings #3 and redhat-developer#6 to reflect stakeholder outcomes

RHDHPLAN-1510 updates:
- Add stakeholder alignment block with RHDHPLAN-393, 404, 1113 outcomes
- RHDHPLAN-393 confirmed complementary, staging in normal ceremonies
- RHDHPLAN-404 provides extended API entity schema for RHOAI connector
- Add llamastack/OGX connector scope
- Update dependency chain and Key Findings #5

RHDHPLAN-1508 and RHDHPLAN-1513: no updates needed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: gabemontero <gmontero@redhat.com>

---------

Signed-off-by: gabemontero <gmontero@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants