Enforce object ownership for more citus-internal UDFs (Backport #8587 to release-12.1) - #8626
Merged
Merged
Conversation
DESCRIPTION: Enforces object-ownership for more citus-internal UDFs for
security.
Backported to release-12.1 with the following adaptations:
- Mapped EnsureCitusInitiatedOperation() to the release-12.1 equivalent
EnsureCoordinatorInitiatedOperation() in citus_internal_add_tenant_schema and
citus_internal_delete_tenant_schema. The 13.x EnsureCitusInitiatedOperation()
("from any node") guard does not exist in 12.1; these UDFs only run their
metadata work locally on the coordinator, and the coordinator-initiated guard
emits the identical error in the out-of-distributed-transaction case.
- Adapted the metadata_sync_helpers regression test to the flat
pg_catalog.citus_internal_<name> UDF naming used in release-12.1 (13.x uses a
dedicated citus_internal schema) and regenerated its expected output.
(cherry picked from commit 10c3a8b)
(cherry picked from commit 96feb25)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-12.1 #8626 +/- ##
================================================
- Coverage 89.65% 89.64% -0.01%
================================================
Files 276 276
Lines 59790 59851 +61
Branches 7471 7480 +9
================================================
+ Hits 53605 53656 +51
- Misses 4041 4047 +6
- Partials 2144 2148 +4 🚀 New features to boost your workflow:
|
onurctirtir
approved these changes
Jun 30, 2026
ihalatci
added a commit
that referenced
this pull request
Jun 30, 2026
…1) (#8629) ## Problem The 1ES self-hosted pool (`1es-gha-citusdata-pool`) is no longer dispatching jobs, so the **required** `check-arbitrary-configs` jobs sit `QUEUED` indefinitely. This blocks **every** open release-12.1 PR (#8519, #8328, #8306, #8626, #8627) from merging despite all other required checks passing. ## Fix Flip the `test-arbitrary-configs` job's `runs-on` from the dead self-hosted 1ES pool to `ubuntu-latest` — a one-line backport of the config already shipping on `main`. ## Why it is safe - `main` already runs this exact job/suite/container on `ubuntu-latest`. - Required-check **names** (`PG14 - check-arbitrary-configs-0`, ...) derive from the job `name:`, not `runs-on`, so branch protection is unaffected. - AC was the **only** job still pinned to the self-hosted pool; everything else already runs github-hosted. ## Rollout Merge this first, then "Update branch" on the 5 open PRs so they inherit the fix and their AC checks run on github-hosted runners. Unblocks the release-12.1 serial-merge queue. Co-authored-by: Ibrahim Halatci <ihalatci@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8587 to
release-12.1.Cherry-picked (
-x) the security fix that enforces object ownership for more citus-internal UDFs. Author (Onur Tirtir) preserved.Adaptations for 12.1
EnsureCitusInitiatedOperation()to the 12.1 equivalentEnsureCoordinatorInitiatedOperation().Verification
regression.diffs.Original PR: #8587