Skip to content

Set 14.2.0 as upcoming version; run N-1 tests against 14.1.0 - #8633

Closed
ihalatci wants to merge 3 commits into
release-14.0from
ihalatci-n-1-14-1-experiment
Closed

Set 14.2.0 as upcoming version; run N-1 tests against 14.1.0 #8633
ihalatci wants to merge 3 commits into
release-14.0from
ihalatci-n-1-14-1-experiment

Conversation

@ihalatci

@ihalatci ihalatci commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Validation experiment — NOT a version bump

This PR consumes the-process #228's dev images (image suffix -dev-9490d30, with /opt/citus-versions/v14.1.0 baked in) to validate whether the latent #8587 N-1 gap reproduces on the 14.x line, mirroring citus #8632 on the 13.x line.

Part B only — .github/workflows/build_and_test.yml (10 lines):

  • image_suffix: -v4271d84-dev-9490d30
  • All 4 N-1 jobs: citus_libdir/opt/citus-versions/v14.1.0, citus_libdir_labelv14.1.0, citus_version14.1-1

No changes to configure.ac, control files, or SQL stubs.

Expected result (prediction)

The N-1 slot on the 14.x line is PG18. Prediction:

Job n_1_mode Prediction
Lib N-1 / PG18 check-multi-1 all FAIL
Coordinator N-1 / PG18 check-multi-1 coordinatoronly FAIL
Worker N-1 / PG18 workeronly PASS
SQL N-1 / PG18 (SQL only) PASS

Why — the 2 reds are pre-existing / orthogonal to the image bump

Regress test create_ref_dist_from_citus_local, line SELECT citus_internal.delete_placement_metadata(1);:

Only coordinator-side loads of the N-1 .so diverge, so Lib N-1 and Coordinator N-1 fail while Worker N-1 and SQL N-1 pass. Because the error string is identical for v14.0.1 and v14.1.0, the image bump does not cause the failure — it is a latent #8587 gap, the same pre-existing condition accepted on 13.x in #8632.

Do not merge

Observe-only. This PR exists to run the N-1 jobs (which only run on pull_request) and confirm the pass/fail matrix above.

ihalatci-msft and others added 2 commits July 1, 2026 06:13
Point the four N-1 check jobs at the-process #228 dev images (suffix -dev-9490d30, v14.1.0 baked in) to validate whether the two 13.x N-1 check-multi-1 reds (Lib N-1, Coordinator N-1) reproduce on the 14.x line.

Part B only: image_suffix -v4271d84 -> -dev-9490d30; N-1 citus_libdir /opt/citus-versions/v14.0.1 -> v14.1.0; N-1 citus_version 14.0-1 -> 14.1-1; N-1 citus_libdir_label v14.0.1 -> v14.1.0. No changes to configure.ac, control files, or SQL stubs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…0 images

The-process #228 published its -dev-9490d30 dev images only at PG minors
16.14/17.10/18.4, but release-14.0 pinned 16.13/17.9/18.3, so every image
pull 404'd (manifest unknown) and all N-1 jobs were skipped. Bump the params
PG minors to match the published tags so the dev images pull cleanly and the
N-1 jobs can run. Workflow-only; image_suffix and the v14.1.0/14.1-1 N-1
edits are unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ihalatci ihalatci changed the title Experiment: N-1 tests against Citus 14.1.0 (release-14.0) Set 14.2.0 as upcoming version; run N-1 tests against 14.1.0 Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.62%. Comparing base (1c80ba2) to head (a7a79b4).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-14.0    #8633      +/-   ##
================================================
- Coverage         88.63%   88.62%   -0.01%     
================================================
  Files               288      288              
  Lines             64116    64115       -1     
  Branches           8046     8045       -1     
================================================
- Hits              56827    56820       -7     
- Misses             4969     4971       +2     
- Partials           2320     2324       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

the-process #229 merged (f4adc47); RELEASE=1 stable images now live on ghcr
at the same PG minors (16.14/17.10/18.4), baking /opt/citus-versions/v14.1.0.
Swap image_suffix -dev-9490d30 -> -vf4adc47 only; N-1 v14.1.0/14.1-1 edits and
PG-minor params unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ihalatci

ihalatci commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Closing this observe-only experiment PR. Its purpose — validating that the latent #8587 N-1 check-multi-1 gap (citus #8632 on the 13.x line) reproduces on the 14.x line — is complete and CI-confirmed across two runs (dev images -dev-9490d30 and stable -vf4adc47): Lib N-1 / PG18 + Coordinator N-1 / PG18 FAIL on the #8587 gap while Worker N-1 + SQL N-1 PASS, exactly as predicted. This branch carries only workflow-only experiment commits. The real Set 14.2.0 as upcoming version work is being prepared as a fresh, self-contained branch off release-14.0 (mirroring the 13.4.0 template commit 4cd5cdd), which supersedes this PR. Not merging.

@ihalatci ihalatci closed this Jul 1, 2026
ihalatci added a commit that referenced this pull request Jul 1, 2026
## Set 14.2.0 as upcoming version

Bumps the in-development version on the `release-14` line from released
**14.1** to upcoming **14.2.0**, and points the N-1 CI slot at
**14.1.0** (previously 14.0.1). This is the direct 14.x analogue of the
13.4.0 bootstrap commit `4cd5cdde5` (*"Set 13.4.0 as upcoming version;
run N-1 tests against 13.3.0"*) and follows the same canonical 12-file
pattern.

### What changed (mirrors the 13.4 template exactly)
- `configure.ac` / `configure` — project version `14.1.0` → `14.2.0`
- `citus.control` / `citus_columnar.control` — `default_version =
'14.2-1'`
- `config.py` — `MASTER_VERSION = "14.2"`
- 4 new comment-only migration stubs: `citus--14.1-1--14.2-1` (+
downgrade) and `citus_columnar--14.1-1--14.2-1` (+ downgrade)
- `multi_extension.sql` / `.out` — 14.2-1 snapshot + downgrade blocks;
`SHOW citus.version` → `14.2.0`; DETAIL lines bumped to `14.2`
- `.github/workflows/build_and_test.yml` — N-1 jobs now run against
`/opt/citus-versions/v14.1.0` / `14.1-1`, stable image suffix
`-vf4adc47`

The workflow half is byte-identical to the earlier CI-validated N-1
experiment. Its only divergence from the 13.4 template is the 5 PG-minor
param bumps (16.14 / 17.10 / 18.4), which the 14.x `-vf4adc47` stable
images were published at.

### N-1 CI expectation (pre-existing, orthogonal)
Running N-1 against 14.1.0 is expected to reproduce the **latent citus
#8587 gap** — the same 2 deterministic `check-multi-1` reds seen on 13.x
(PR #8632): **Lib N-1 / PG18** and **Coordinator N-1 / PG18** fail on
`create_ref_dist_from_citus_local` (`delete_placement_metadata(1)`);
**Worker N-1** and **SQL N-1** pass. This was confirmed across two runs
during the validation experiment (closed PR #8633) and is pre-existing /
orthogonal to this version bump.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Ibrahim Halatci <ihalatci@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants