Produce stable image suffix on release-14 merges (symmetric with release-13)#229
Merged
Merged
Conversation
Make the release-14 build-test-images workflow symmetric with release-13: merging into any release-* branch (not just master) now fires the release image jobs, minting a stable -v<sha> suffix instead of -dev-<sha>. Feature and PR branches still publish -dev images. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the
release-14build-test-imagesworkflow symmetric withrelease-13.Problem: On
release-13the release image jobs fire for anyrelease-*branch, so merging intorelease-13mints a stable-v<sha>suffix. Onrelease-14the jobs are gated tomasteronly, so merging intorelease-14produced only-dev-<sha>images (no stable-vsuffix) — e.g. #228 merged and yielded only-dev-877ec08.Fix (surgical, 4 lines): widen the branch guards so
release-*merges route to the release jobs while feature/PR branches keep producing-devimages:build_dev_images_per_postgres/build_dev_images_shared:!= 'master'→!= 'master' && !startsWith(github.ref_name, 'release-')build_release_images/build_release_images_shared:== 'master'→== 'master' || startsWith(github.ref_name, 'release-')The two guards remain mutually exclusive, so no job double-fires. Behaviorally symmetric to
release-13.Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com