Update donation page#218
Merged
Merged
Conversation
5 tasks
mkalish
reviewed
Dec 14, 2017
| // Get the token ID to your server-side code for use. | ||
| // The "00" is there because Stripe deals in cents rather than dollars, but the form | ||
| // only asks for a whole dollar amount. | ||
| var amount = Number(document.getElementById('donation-amount').value + "00") |
Member
There was a problem hiding this comment.
Super nitpick, but these should probably be const
| "email": token.email, | ||
| "account": account | ||
| }); | ||
| $.post("https://b9sq87esw7.execute-api.us-east-2.amazonaws.com/prod/codefordc-stripe-processor", send, function(data, status){ |
Member
There was a problem hiding this comment.
Is this in the codefordc aws account?
Member
Author
There was a problem hiding this comment.
No, the District Civic Labs one. We should discuss consolidation and/or access for you.
Member
There was a problem hiding this comment.
Cool, are you free to meet for a half hour this weekend next week to figure it out?
Member
Author
There was a problem hiding this comment.
Yeah, there should be something available. I'll follow up with you.
mkalish
approved these changes
Jan 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches from a link to the CFA donation page to an embedded form that'll deposit straight to the account managed by District Civic Labs. It uses Stripe and AWS Lambda to make things work behind the scenes.
The Lambda URL could use some DNS beautifying, but that can be included in this pull request or updated later.