Re-add support for comment descriptions#230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: #229
When bumping
graphql-jsto v15, I mistakenly interpreted some test failures asgraphql-jsno longer supporting comment descriptions. This was a mistake. The functiongraphql-schema-linterrelies on ingraphql-jswas simply moved to a different file.This PR fixes the original issue and re-adds support for comment descriptions.
While comment descriptions are deprecated in
graphql-js, they are only scheduled to be removed fromgraphql-jsin v16 as per: https://github.com/graphql/graphql-js/blob/8ddef3331aa2bbf0293fffb7a72acc292fa44bc3/src/utilities/extendSchema.d.ts#L61-L70.