Polish CLASS - drop BMI, update runner, add output metadata#138
Merged
Polish CLASS - drop BMI, update runner, add output metadata#138
Conversation
…use real axis extent rather than fixes base/top pressure
… they don't tilt anymore
…output vars; however, app/model hangs on second or third run
Merged
Peter9192
changed the title
Moved docstring of bmi.ts:BmiClass:run() to runClass
sverhoeven
approved these changes
Apr 24, 2025
Collaborator
sverhoeven
left a comment
sverhoeven
left a comment
There was a problem hiding this comment.
Still works in app, cli and docs.
| ]; | ||
|
|
||
| export type ClassOutput = { | ||
| [K in (typeof outputVariables)[number]["key"]]: number[]; |
Collaborator
There was a problem hiding this comment.
I think the idea of this is to have ClassOutput type be
type ClassOutput = {
t: number[];
h: number[];
theta: number[];
dtheta: number[];
q: number[];
dq: number[];
dthetav: number[];
we: number[];
ws: number[];
wthetave: number[];
wthetav: number[];
}however it is
type ClassOutput = {
[x: string]: number[];
}I quickly tried to typing outputVariables with as const satisfies readonly OutputVariable[], but that broke things downstream and did not have time to fix all those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip BMI - it unnecessarily complicates things
Use runner from package instead
Update output variables in runner and use the metadata for nicer axis labels etc. in app
merge after #137