fix(soot): add unique controller names to prevent metric conflicts#1043
Merged
prometherion merged 1 commit intoclastix:masterfrom Jan 4, 2026
Merged
Conversation
✅ Deploy Preview for kamaji-documentation canceled.
|
syedazeez337
force-pushed
the
fix/issue-1025-negative-metrics
branch
from
7eb959e to
f5d88fc
Compare
prometherion
approved these changes
Dec 29, 2025
Member
prometherion
left a comment
prometherion
left a comment
There was a problem hiding this comment.
Well done on doing this investigation @syedazeez337, if CI is green, happy to get this merged!
Fixes clastix#1025 Previously, all soot managers (one per TenantControlPlane) created controllers with identical names (e.g., 'clusterrolebinding', 'configmap'). These controllers registered metrics with the same labels in the global Prometheus registry, causing worker count conflicts and negative values when TenantControlPlanes were dynamically created/destroyed. This fix adds unique controller names by: - Adding a ControllerName field to all soot controller structs - Using .Named() in SetupWithManager with a unique name per TCP - Generating names as {namespace}-{name}-{controller-type} Now each TenantControlPlane's controllers have unique metric labels, preventing conflicts and eliminating negative worker counts. Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
syedazeez337
force-pushed
the
fix/issue-1025-negative-metrics
branch
from
f5d88fc to
5127f80
Compare
Contributor
Author
|
Hi @prometherion |
prometherion
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1025
Previously, all soot managers (one per TenantControlPlane) created controllers with identical names (e.g., 'clusterrolebinding', 'configmap'). These controllers registered metrics with the same labels in the global Prometheus registry, causing worker count conflicts and negative values when TenantControlPlanes were dynamically created/destroyed.
This fix adds unique controller names by:
Now each TenantControlPlane's controllers have unique metric labels, preventing conflicts and eliminating negative worker counts.